Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: components/translate/core/browser/translate_ranker.cc

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: review candidate Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker.h" 5 #include "components/translate/core/browser/translate_ranker.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 58 }
59 59
60 GURL GetTranslateRankerURL() { 60 GURL GetTranslateRankerURL() {
61 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); 61 base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
62 return GURL(command_line->HasSwitch(switches::kTranslateRankerModelURL) 62 return GURL(command_line->HasSwitch(switches::kTranslateRankerModelURL)
63 ? command_line->GetSwitchValueASCII( 63 ? command_line->GetSwitchValueASCII(
64 switches::kTranslateRankerModelURL) 64 switches::kTranslateRankerModelURL)
65 : kTranslateRankerModelURL); 65 : kTranslateRankerModelURL);
66 } 66 }
67 67
68 bool IsQueryEnabled() {
69 return base::FeatureList::IsEnabled(kTranslateRankerQuery);
70 }
71
72 bool IsEnforcementEnabled() {
73 return base::FeatureList::IsEnabled(kTranslateRankerEnforcement);
74 }
75
76 void ReportModelStatus(ModelStatus model_status) { 68 void ReportModelStatus(ModelStatus model_status) {
77 UMA_HISTOGRAM_ENUMERATION("Translate.Ranker.Model.Status", model_status, 69 UMA_HISTOGRAM_ENUMERATION("Translate.Ranker.Model.Status", model_status,
78 MODEL_STATUS_MAX); 70 MODEL_STATUS_MAX);
79 } 71 }
80 72
81 } // namespace 73 } // namespace
82 74
83 const base::Feature kTranslateRankerQuery{"TranslateRankerQuery", 75 const base::Feature kTranslateRankerQuery{"TranslateRankerQuery",
84 base::FEATURE_DISABLED_BY_DEFAULT}; 76 base::FEATURE_DISABLED_BY_DEFAULT};
85 77
86 const base::Feature kTranslateRankerEnforcement{ 78 const base::Feature kTranslateRankerEnforcement{
87 "TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT}; 79 "TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT};
88 80
89 TranslateRanker::~TranslateRanker() {} 81 TranslateRanker::~TranslateRanker() {}
90 82
91 // static 83 // static
92 bool TranslateRanker::IsEnabled() { 84 bool TranslateRanker::IsEnabled() {
93 return IsQueryEnabled() || IsEnforcementEnabled(); 85 return IsQueryEnabled() || IsEnforcementEnabled();
94 } 86 }
95 87
96 // static 88 // static
89 bool TranslateRanker::IsQueryEnabled() {
90 return base::FeatureList::IsEnabled(kTranslateRankerQuery);
91 }
92
93 // static
94 bool TranslateRanker::IsEnforcementEnabled() {
95 return base::FeatureList::IsEnabled(kTranslateRankerEnforcement);
96 }
97
98 // static
97 TranslateRanker* TranslateRanker::GetInstance() { 99 TranslateRanker* TranslateRanker::GetInstance() {
98 return base::Singleton<TranslateRanker>::get(); 100 return base::Singleton<TranslateRanker>::get();
99 } 101 }
100 102
101 std::unique_ptr<TranslateRanker> TranslateRanker::CreateForTesting( 103 std::unique_ptr<TranslateRanker> TranslateRanker::CreateForTesting(
102 const std::string& model_data) { 104 const std::string& model_data) {
103 std::unique_ptr<TranslateRanker> ranker(new TranslateRanker()); 105 std::unique_ptr<TranslateRanker> ranker(new TranslateRanker());
104 CHECK(ranker != nullptr); 106 CHECK(ranker != nullptr);
105 ranker->ParseModel(0, true, model_data); 107 ranker->ParseModel(0, true, model_data);
106 CHECK(ranker->model_ != nullptr); 108 CHECK(ranker->model_ != nullptr);
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 ReportModelStatus(MODEL_STATUS_VALIDATION_FAILED); 278 ReportModelStatus(MODEL_STATUS_VALIDATION_FAILED);
277 return; 279 return;
278 } 280 }
279 281
280 ReportModelStatus(MODEL_STATUS_OK); 282 ReportModelStatus(MODEL_STATUS_OK);
281 model_ = std::move(new_model); 283 model_ = std::move(new_model);
282 model_fetcher_.reset(); 284 model_fetcher_.reset();
283 } 285 }
284 286
285 } // namespace translate 287 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698