Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: moar ShowTranslateBubbleResult plumbing Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "chrome/browser/lifetime/browser_close_manager.h" 10 #include "chrome/browser/lifetime/browser_close_manager.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 namespace signin_metrics { 61 namespace signin_metrics {
62 enum class AccessPoint; 62 enum class AccessPoint;
63 } 63 }
64 64
65 namespace web_modal { 65 namespace web_modal {
66 class WebContentsModalDialogHost; 66 class WebContentsModalDialogHost;
67 } 67 }
68 68
69 enum class ImeWarningBubblePermissionStatus; 69 enum class ImeWarningBubblePermissionStatus;
70 70
71 enum class ShowTranslateBubbleResult {
72 SUCCESS,
73 BROWSER_WINDOW_NOT_VALID,
74 BROWSER_WINDOW_MINIMIZED,
75 BROWSER_WINDOW_NOT_ACTIVE,
76 WEBCONTENTS_NOT_ACTIVE,
sky 2016/11/11 19:07:40 WEB_CONTENTS
Roger McFarlane (Chromium) 2016/11/11 19:55:09 Done.
77 EDITABLE_FIELD_IS_ACTIVE,
78 };
79
71 //////////////////////////////////////////////////////////////////////////////// 80 ////////////////////////////////////////////////////////////////////////////////
72 // BrowserWindow interface 81 // BrowserWindow interface
73 // An interface implemented by the "view" of the Browser window. 82 // An interface implemented by the "view" of the Browser window.
74 // This interface includes ui::BaseWindow methods as well as Browser window 83 // This interface includes ui::BaseWindow methods as well as Browser window
75 // specific methods. 84 // specific methods.
76 // 85 //
77 // NOTE: All getters may return NULL. 86 // NOTE: All getters may return NULL.
78 // 87 //
79 class BrowserWindow : public ui::BaseWindow { 88 class BrowserWindow : public ui::BaseWindow {
80 public: 89 public:
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 // Shows the "Save credit card" bubble. 244 // Shows the "Save credit card" bubble.
236 virtual autofill::SaveCardBubbleView* ShowSaveCreditCardBubble( 245 virtual autofill::SaveCardBubbleView* ShowSaveCreditCardBubble(
237 content::WebContents* contents, 246 content::WebContents* contents,
238 autofill::SaveCardBubbleController* controller, 247 autofill::SaveCardBubbleController* controller,
239 bool is_user_gesture) = 0; 248 bool is_user_gesture) = 0;
240 249
241 // Shows the translate bubble. 250 // Shows the translate bubble.
242 // 251 //
243 // |is_user_gesture| is true when the bubble is shown on the user's deliberate 252 // |is_user_gesture| is true when the bubble is shown on the user's deliberate
244 // action. 253 // action.
245 virtual void ShowTranslateBubble( 254 virtual ShowTranslateBubbleResult ShowTranslateBubble(
246 content::WebContents* contents, 255 content::WebContents* contents,
247 translate::TranslateStep step, 256 translate::TranslateStep step,
248 translate::TranslateErrors::Type error_type, 257 translate::TranslateErrors::Type error_type,
249 bool is_user_gesture) = 0; 258 bool is_user_gesture) = 0;
250 259
251 #if BUILDFLAG(ENABLE_ONE_CLICK_SIGNIN) 260 #if BUILDFLAG(ENABLE_ONE_CLICK_SIGNIN)
252 // Callback type used with the ShowOneClickSigninConfirmation() method. If the 261 // Callback type used with the ShowOneClickSigninConfirmation() method. If the
253 // user chooses to accept the sign in, the callback is called to start the 262 // user chooses to accept the sign in, the callback is called to start the
254 // sync process. 263 // sync process.
255 typedef base::Callback<void(OneClickSigninSyncStarter::StartSyncMode)> 264 typedef base::Callback<void(OneClickSigninSyncStarter::StartSyncMode)>
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 virtual std::string GetWorkspace() const = 0; 390 virtual std::string GetWorkspace() const = 0;
382 virtual bool IsVisibleOnAllWorkspaces() const = 0; 391 virtual bool IsVisibleOnAllWorkspaces() const = 0;
383 392
384 protected: 393 protected:
385 friend class BrowserCloseManager; 394 friend class BrowserCloseManager;
386 friend class BrowserView; 395 friend class BrowserView;
387 virtual void DestroyBrowser() = 0; 396 virtual void DestroyBrowser() = 0;
388 }; 397 };
389 398
390 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 399 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698