[Translate] Integrate TranslateEventProto UMA logging into TranslateManager.

components/translate/core/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 
 static_library("browser") {
   sources = [
     "language_model.cc",
     "language_model.h",
@@ skipping 49 matching lines @@
     "//components/translate/core/browser/proto",
     "//components/translate/core/common",
     "//components/variations",
     "//google_apis",
     "//net",
     "//third_party/icu",
     "//ui/base",
     "//url",
   ]
 
+  public_deps = [
+    "//components/metrics/proto",

[hamelphi, 2016/10/13 15:13:56]

This dependency is also in deps. I suppose we only need it once. If I understand
public_deps correctly, you can remove the deps here and in unit_test.

[Roger McFarlane (Chromium), 2016/10/13 19:30:16]

fixed

the public_deps is needed: public_deps is transitive, deps is not.

public_deps is needed because the translate event proto header is included in
translate_manager.h, which is included elsewhere.

I could remove the public_deps by holding the proto via a unique_ptr, but the
lifecycle of the proto and the translate manager are exactly the same, so it
makes more sense for it to be a direct member.

[hamelphi, 2016/10/13 20:47:02]

My point was that you probably can remove "//components/metrics/proto" in the
'deps' section since you add it to public_deps. But I might be wrong. In any
case, I don't feel strongly.

[Roger McFarlane (Chromium), 2016/10/14 19:59:05]

ah... yeah, that's what I did. I thought you were suggesting the opposite. sorry
for the confusion.

+  ]
+
   if (!use_aura) {
     sources += [
       "translate_infobar_delegate.cc",
       "translate_infobar_delegate.h",
     ]
     deps += [ "//components/infobars/core" ]
   }
 
   if (is_mac) {
     sources += [
@@ skipping 26 matching lines @@
     "//components/pref_registry:test_support",
     "//components/prefs",
     "//components/prefs:test_support",
     "//components/translate/core/browser/proto",
     "//components/translate/core/common",
     "//components/variations",
     "//net:test_support",
     "//testing/gtest",
   ]
 }