runtime/lib/mirrors.cc - Issue 24005002: Make TypedefMirror a direct descendant of TypeMirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors.cc

Issue 24005002: Make TypedefMirror a direct descendant of TypeMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors.cc

diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc

index 754aa5f82df967574e1898f8cbb33abd062fc827..46dc79649db58150d569260772e23d4007b2d953 100644

--- a/runtime/lib/mirrors.cc

+++ b/runtime/lib/mirrors.cc

@@ -741,7 +741,9 @@ DEFINE_NATIVE_ENTRY(Mirrors_makeLocalClassMirror, 1) {

GET_NON_NULL_NATIVE_ARGUMENT(Type, type, arguments->NativeArgAt(0));

const Class& cls = Class::Handle(type.type_class());

ASSERT(!cls.IsNull());

- if (cls.IsDynamicClass() || cls.IsVoidClass()) {

+ if (cls.IsDynamicClass() ||

+ cls.IsVoidClass() ||

+ (cls.IsSignatureClass() && !cls.IsCanonicalSignatureClass())) {

Exceptions::ThrowArgumentError(type);

UNREACHABLE();

}

« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | sdk/lib/mirrors/mirrors.dart » ('J')