Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2400493002: Select GN build with an environment variable (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Select GN build with an environment variable Setting DART_USE_GN to anything will cause 'gclient runhooks' and build.py to use GN. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c67bd01d76f3e0db0e10bbc16a36ddf9df2e7218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/build.py View 2 chunks +8 lines, -1 line 0 comments Download
A tools/generate_buildfiles.py View 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-10-05 20:39:55 UTC) #2
Cutch
lgtm
4 years, 2 months ago (2016-10-05 20:45:32 UTC) #3
zra
4 years, 2 months ago (2016-10-05 21:07:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c67bd01d76f3e0db0e10bbc16a36ddf9df2e7218 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698