Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2400463003:
Skip some mozilla tests on turbofan_opt as they consistently timeout (Closed)
|
Created:
4 years, 2 months ago by adamk Modified:
4 years, 2 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionSkip some mozilla tests on turbofan_opt as they consistently timeout
These tests were marked as NO_VARIANTS under debug, but they were timing
out under turbofan_opt as well on the CFI bot (see, e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/6765).
R=machenbach@chromium.org
Committed: https://crrev.com/2c60ecf6e44b6f619207bb3b06339e0fccb1611a
Cr-Commit-Position: refs/heads/master@{#40103}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Add turbofan_opt section #Messages
Total messages: 20 (12 generated)
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2400463003/diff/1/test/mozilla/mozilla.status File test/mozilla/mozilla.status (right): https://codereview.chromium.org/2400463003/diff/1/test/mozilla/mozilla.status... test/mozilla/mozilla.status:183: 'js1_5/Regress/regress-360969-05': [PASS, ['mode == debug', TIMEOUT], NO_VARIANTS], We might soon have a fix-it to get rid of these approximations, so I'd rather not create more. This affects only cfi and turbofan_opt. We don't have a variable for cfi yet, but for the variant, better create a new section for turbofan_opt only and add a comment that clearly states the reason at the expectation lines (i.e. the cfi bot).
Now that you're at it, I assume you saw this? https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...
Description was changed from ========== Mark some slow mozilla tests as NO_VARIANTS more broadly These tests were marked as NO_VARIANTS under debug, but they were timing out under some variants as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...). R=machenbach@chromium.org ========== to ========== Skip some mozilla tests on turbofan_opt as they consistently timeout These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...). R=machenbach@chromium.org ==========
Thanks for the pointer to the spread failure, I've uploaded a fix for that separately. Out of curiosity, why is the CFI bot FYI-only? The spread failure was a real bug, would have been nice for it to close the tree. https://codereview.chromium.org/2400463003/diff/1/test/mozilla/mozilla.status File test/mozilla/mozilla.status (right): https://codereview.chromium.org/2400463003/diff/1/test/mozilla/mozilla.status... test/mozilla/mozilla.status:183: 'js1_5/Regress/regress-360969-05': [PASS, ['mode == debug', TIMEOUT], NO_VARIANTS], On 2016/10/07 12:34:17, machenbach (slow) wrote: > We might soon have a fix-it to get rid of these approximations, so I'd rather > not create more. > > This affects only cfi and turbofan_opt. > > We don't have a variable for cfi yet, but for the variant, better create a new > section for turbofan_opt only and add a comment that clearly states the reason > at the expectation lines (i.e. the cfi bot). Done.
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, thanks On 2016/10/07 22:10:39, adamk wrote: > Thanks for the pointer to the spread failure, I've uploaded a fix for that > separately. Out of curiosity, why is the CFI bot FYI-only? The spread failure > was a real bug, would have been nice for it to close the tree. The script that downloads the plugin has a bug and breaks on every clang roll - and needs a manual clobber. Never got to fixing it.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Skip some mozilla tests on turbofan_opt as they consistently timeout These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...). R=machenbach@chromium.org ========== to ========== Skip some mozilla tests on turbofan_opt as they consistently timeout These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...). R=machenbach@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Skip some mozilla tests on turbofan_opt as they consistently timeout These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...). R=machenbach@chromium.org ========== to ========== Skip some mozilla tests on turbofan_opt as they consistently timeout These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds...). R=machenbach@chromium.org Committed: https://crrev.com/2c60ecf6e44b6f619207bb3b06339e0fccb1611a Cr-Commit-Position: refs/heads/master@{#40103} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2c60ecf6e44b6f619207bb3b06339e0fccb1611a Cr-Commit-Position: refs/heads/master@{#40103} |
