Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2400463002: Eliminate use of StringPiece(nullptr, n) with non zero n. (Closed)

Created:
4 years, 2 months ago by dahollings
Modified:
4 years, 2 months ago
Reviewers:
Buck, mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate use of StringPiece(nullptr, n) with non zero n. This CL lands server change 135025499 by rogeeff. BUG=488484 Committed: https://crrev.com/2ddac2b527c5ec66aa403c379ec67af9923704ad Cr-Commit-Position: refs/heads/master@{#423651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M net/spdy/spdy_framer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M net/spdy/spdy_protocol.h View 3 chunks +17 lines, -5 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M net/spdy/spdy_protocol_test.cc View 2 chunks +10 lines, -17 lines 0 comments Download
M net/spdy/spdy_protocol_test_utils.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (26 generated)
dahollings
bnc@ and rch@ are OOO I believe, feel free to reassign.
4 years, 2 months ago (2016-10-05 23:06:43 UTC) #22
Buck
lgtm
4 years, 2 months ago (2016-10-06 17:09:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400463002/160001
4 years, 2 months ago (2016-10-06 17:11:41 UTC) #25
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-06 17:11:43 UTC) #27
dahollings
Hi mef@, Our usual 'full committers' (bnc@ and rch@) are out this week, hoping you ...
4 years, 2 months ago (2016-10-06 17:24:48 UTC) #29
mef
rubber-stamp lgtm
4 years, 2 months ago (2016-10-06 20:01:18 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400463002/160001
4 years, 2 months ago (2016-10-06 20:17:10 UTC) #32
commit-bot: I haz the power
Committed patchset #1 (id:160001)
4 years, 2 months ago (2016-10-06 20:23:16 UTC) #33
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:25:45 UTC) #35
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ddac2b527c5ec66aa403c379ec67af9923704ad
Cr-Commit-Position: refs/heads/master@{#423651}

Powered by Google App Engine
This is Rietveld 408576698