|
|
Created:
4 years, 2 months ago by dahollings Modified:
4 years, 2 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEliminate use of StringPiece(nullptr, n) with non zero n.
This CL lands server change 135025499 by rogeeff.
BUG=488484
Committed: https://crrev.com/2ddac2b527c5ec66aa403c379ec67af9923704ad
Cr-Commit-Position: refs/heads/master@{#423651}
Patch Set 1 #
Messages
Total messages: 35 (26 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
The CQ bit was checked by dahollings@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dahollings@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:100001) has been deleted
The CQ bit was checked by dahollings@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:120001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by dahollings@chromium.org to run a CQ dry run
Patchset #1 (id:140001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dahollings@chromium.org changed reviewers: + ckrasic@chromium.org
bnc@ and rch@ are OOO I believe, feel free to reassign.
lgtm
The CQ bit was checked by dahollings@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
dahollings@chromium.org changed reviewers: + mef@chromium.org
Hi mef@, Our usual 'full committers' (bnc@ and rch@) are out this week, hoping you could give an lgtm on this merge of SPDY google3 code or suggest someone more appropriate. Thanks!
rubber-stamp lgtm
The CQ bit was checked by dahollings@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Eliminate use of StringPiece(nullptr, n) with non zero n. This CL lands server change 135025499 by rogeeff. BUG=488484 ========== to ========== Eliminate use of StringPiece(nullptr, n) with non zero n. This CL lands server change 135025499 by rogeeff. BUG=488484 Committed: https://crrev.com/2ddac2b527c5ec66aa403c379ec67af9923704ad Cr-Commit-Position: refs/heads/master@{#423651} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2ddac2b527c5ec66aa403c379ec67af9923704ad Cr-Commit-Position: refs/heads/master@{#423651} |