Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2400443006: VideoCapture: moar VideoCapture renderer-->host messages to mojo, part 3 (Closed)

Created:
4 years, 2 months ago by mcasas
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, chfremer
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCapture: moar VideoCapture renderer-->host messages to mojo, part 3 This time is GetDeviceSupportedFormats and GetDeviceFormatsInUse, which encompass a command-with-response that are bundled into a mojo with result in a callback (which allows for simplifying a bit the sender side in VideoCaptureImpl, as we don't need a list of callbacks in-flight). BUG=651897 Committed: https://crrev.com/1129536744aa7afa34fdf48725e9a0012afeaee6 Cr-Commit-Position: refs/heads/master@{#423942}

Patch Set 1 : #

Patch Set 2 : minor rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -197 lines) Patch
M content/browser/renderer_host/media/video_capture_host.h View 2 chunks +8 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 3 chunks +28 lines, -36 lines 0 comments Download
M content/common/media/video_capture_messages.h View 2 chunks +0 lines, -22 lines 0 comments Download
M content/common/video_capture.mojom View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 3 chunks +7 lines, -11 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 3 chunks +23 lines, -27 lines 0 comments Download
M content/renderer/media/video_capture_impl_manager_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 7 chunks +26 lines, -17 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 2 chunks +0 lines, -18 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mcasas
chfremer@ PTAL tsepez@ RS plz, more message migration.
4 years, 2 months ago (2016-10-07 16:04:40 UTC) #5
Tom Sepez
messages/mojom LGTM
4 years, 2 months ago (2016-10-07 17:48:02 UTC) #7
chfremer
lgtm
4 years, 2 months ago (2016-10-07 18:08:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400443006/40001
4 years, 2 months ago (2016-10-07 18:29:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-07 19:50:41 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 19:52:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1129536744aa7afa34fdf48725e9a0012afeaee6
Cr-Commit-Position: refs/heads/master@{#423942}

Powered by Google App Engine
This is Rietveld 408576698