Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2400443004: Walk up frame tree for srcdoc referrer policies (Closed)

Created:
4 years, 2 months ago by estark
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Walk up frame tree for srcdoc referrer policies When deciding the referrer policy for a srcdoc document, walk up the frame tree until we find a non-srcdoc document OR a srcdoc document with its own policy set via a meta element. This implements the algorithm defined in https://html.spec.whatwg.org/multipage/browsers.html#set-up-a-browsing-context-environment-settings-object. However, the spec'ed algorithm has to be adjusted per https://github.com/whatwg/html/pull/1559#issuecomment-251767893 to account for meta elements in srcdoc documents (which this CL implements). BUG=653034, 637007 Committed: https://crrev.com/618cf68c2fc06d58857f4bd44a26737fbe9a2494 Cr-Commit-Position: refs/heads/master@{#423538}

Patch Set 1 #

Patch Set 2 : fix dynamic policy test #

Messages

Total messages: 14 (9 generated)
estark
jochen: another referrer policy bug fix for you, PTAL
4 years, 2 months ago (2016-10-06 12:47:25 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-06 12:52:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400443004/20001
4 years, 2 months ago (2016-10-06 15:17:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 15:23:42 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:27:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/618cf68c2fc06d58857f4bd44a26737fbe9a2494
Cr-Commit-Position: refs/heads/master@{#423538}

Powered by Google App Engine
This is Rietveld 408576698