Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2400333003: Enforce comment formatting in core/layout as well. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
10 * 10 *
(...skipping 724 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 } 735 }
736 736
737 // Below we are handling only row(s) who have at least one visible cell 737 // Below we are handling only row(s) who have at least one visible cell
738 // without rowspan value. 738 // without rowspan value.
739 float totalPercent = 0; 739 float totalPercent = 0;
740 int totalAutoRowsHeight = 0; 740 int totalAutoRowsHeight = 0;
741 int totalRemainingRowsHeight = spanningRowsHeight.totalRowsHeight; 741 int totalRemainingRowsHeight = spanningRowsHeight.totalRowsHeight;
742 742
743 // FIXME: Inner spanning cell height should not change if it have fixed 743 // FIXME: Inner spanning cell height should not change if it have fixed
744 // height when it's parent spanning cell is distributing it's extra height 744 // height when it's parent spanning cell is distributing it's extra height
745 //in rows. 745 // in rows.
746 746
747 // Calculate total percentage, total auto rows height and total rows height 747 // Calculate total percentage, total auto rows height and total rows height
748 // except percent rows. 748 // except percent rows.
749 for (unsigned row = rowIndex; row < spanningCellEndIndex; row++) { 749 for (unsigned row = rowIndex; row < spanningCellEndIndex; row++) {
750 // TODO(alancutter): Make this work correctly for calc lengths. 750 // TODO(alancutter): Make this work correctly for calc lengths.
751 if (m_grid[row].logicalHeight.isPercent()) { 751 if (m_grid[row].logicalHeight.isPercent()) {
752 totalPercent += m_grid[row].logicalHeight.percent(); 752 totalPercent += m_grid[row].logicalHeight.percent();
753 totalRemainingRowsHeight -= 753 totalRemainingRowsHeight -=
754 spanningRowsHeight.rowHeight[row - rowIndex]; 754 spanningRowsHeight.rowHeight[row - rowIndex];
755 } else if (m_grid[row].logicalHeight.isAuto()) { 755 } else if (m_grid[row].logicalHeight.isAuto()) {
(...skipping 1242 matching lines...) Expand 10 before | Expand all | Expand 10 after
1998 // the header in all columns. 1998 // the header in all columns.
1999 // Note that this is in flow thread coordinates, not visual coordinates. The 1999 // Note that this is in flow thread coordinates, not visual coordinates. The
2000 // enclosing LayoutFlowThread will convert to visual coordinates. 2000 // enclosing LayoutFlowThread will convert to visual coordinates.
2001 if (table()->header() == this && isRepeatingHeaderGroup()) 2001 if (table()->header() == this && isRepeatingHeaderGroup())
2002 rect.setHeight(table()->logicalHeight()); 2002 rect.setHeight(table()->logicalHeight());
2003 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect, 2003 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect,
2004 flags); 2004 flags);
2005 } 2005 }
2006 2006
2007 } // namespace blink 2007 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/.clang-format ('k') | third_party/WebKit/Source/core/layout/ListMarkerText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698