Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 2400303004: Don't repeat headers if at least one row of content doesn't fit (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Don't repeat headers if at least one row of content doesn't fit The spec (https://drafts.csswg.org/css-tables-3/#repeated-headers) tells us that we shouldn't bother repeating headers if a row of content doesn't fit. It's not clear what to do in the situation where it's just the first page that the row doesn't fit. I think we ultimately want to do the same as Edge/IE and still repeat the headers on subsequent pages. That would require a second layout pass to achieve so for now just drop the repeating headers if we can't fit a row on the first page. BUG=624814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2326303002 Cr-Commit-Position: refs/heads/master@{#418838} (cherry picked from commit 8bf47bb4e1d0ea9599bc443906fc26c3ce86f152) Committed: https://chromium.googlesource.com/chromium/src/+/ee7ca0fdc96ab4ba61d0be876c8e779adced302d

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
rhogan
4 years, 2 months ago (2016-10-08 12:00:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee7ca0fdc96ab4ba61d0be876c8e779adced302d.

Powered by Google App Engine
This is Rietveld 408576698