Update UI and catch executeScript errors now shown in Canary

go-back-with-backspace/pages/popup.js

Index: go-back-with-backspace/pages/popup.js
diff --git a/go-back-with-backspace/pages/popup.js b/go-back-with-backspace/pages/popup.js
index aa4666b36a9a700dd2dbb537e8395eceb768379d..ece02fdcd44f7e3070fa7737713561d6173f0ac9 100644
--- a/go-back-with-backspace/pages/popup.js
+++ b/go-back-with-backspace/pages/popup.js
@@ -25,7 +25,7 @@ function urlAllowed(url, file_ok) {
 // Update the popup display depending on the current options and the URL of
 // the current page.
 function updatePopup(options, url) {
-  var button = document.getElementById('list_edit_button');
+  var button = document.getElementById('list-edit-button');
 
   if (!urlAllowed(url, options.file_ok)) {
     button.textContent = chrome.i18n.getMessage('popupAddBlacklist');
@@ -40,7 +40,7 @@ function updatePopup(options, url) {
   // If the current page is prohibited because it's a file:// scheme, show a
   // link to chrome://extensions, where that setting can be changed.
   if (!options.file_ok && url.startsWith('file://')) {
-    document.getElementById('file_url_message').hidden = false;
+    document.getElementById('file-url-message').hidden = false;
     document.getElementById('status').hidden = true;
   }
 }
@@ -62,13 +62,11 @@ function setStatus(message_id, placeholder) {
 
 // Initialize the page.
 function init() {
-  LoadInternationalizedStrings();
+  loadInternationalizedStrings();
 
   // Load the active tab's URL, then set up page features that depend on it.
   chrome.tabs.query({active: true, currentWindow: true}, function(tabList) {
     var url = tabList[0].url;
-    var element = document.getElementById('current_url');
-    element.textContent = chrome.i18n.getMessage('popupCurrentURL', url);
 
     // Load settings.
     var options = {};
@@ -86,7 +84,7 @@ function init() {
     });
 
     // Set event handlers that depend on the URL.
-    document.getElementById('list_edit_button').onclick = function() {
+    document.getElementById('list-edit-button').onclick = function() {
       var index = options.blacklist.indexOf(url);
       if (index > -1)
         options.blacklist.splice(index, 1);
@@ -106,17 +104,17 @@ function init() {
       });
     };
 
-    document.getElementById('report_page').onclick = function() {
-      reportPage(url);
+    document.getElementById('feedback-link').onclick = function() {

[Devlin, 2016/11/01 15:12:15]

Same comments

[Pam (message me for reviews), 2016/11/01 21:29:03]

Done, except that these two need to stay inside anonymous functions.
sendFeedback because it needs an argument, and openOptionsPage because otherwise
it gets the event passed as the first arg, which confuses the extension
parameter parser.

+      sendFeedback(url);
     };
   });
 
   // Set event handlers that don't need the URL.
-  document.getElementById('open_options').onclick = function() {
+  document.getElementById('options-link').onclick = function() {
     chrome.runtime.openOptionsPage();
   };
 
-  document.getElementById('open_extensions').onclick = function() {
+  document.getElementById('open-extensions').onclick = function() {
     chrome.tabs.create({url: 'chrome://extensions', active:true});
     window.close();
   };