Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: go-back-with-backspace/pages/popup.html

Issue 2400303003: Update UI and catch executeScript errors now shown in Canary (Closed)
Patch Set: Fix global-replace bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go-back-with-backspace/pages/popup.html
diff --git a/go-back-with-backspace/pages/popup.html b/go-back-with-backspace/pages/popup.html
index ff4d6eda8dfdf0b2031f87108af1cf925e9f8f11..5e6a01192e9e7132e501a68ec818f59492c84bc1 100644
--- a/go-back-with-backspace/pages/popup.html
+++ b/go-back-with-backspace/pages/popup.html
@@ -7,20 +7,27 @@
<body>
<h1 i18n="extensionName"></h1>
- <div id="current_url"></div>
- <div>
- <button i18n="popupAddBlacklist" id="list_edit_button"></button><br>
- </div>
+ <button i18n="popupAddBlacklist" id="list-edit-button"></button><br>
- <div id="messages">
- <div id="status">&nbsp;</div>
- <div id="file_url_message" hidden>
- <a href="" i18n="popupFileURL" id="open_extensions"></a>
- </div>
+ <div id="file-url-message" hidden>
+ <a href="" i18n="popupFileURL" id="open-extensions"></a>
</div>
- <a href="" i18n="sendFeedback" id="report_page"></a>
- <a href="" i18n="openOptions" id="open_options"></a>
+ <div class="bottom-bar">
+ <span id="feedback-button">
+ <a href="" id="feedback-link" class="image-link">
Devlin 2016/11/01 15:12:15 won't href default to ''?
Pam (message me for reviews) 2016/11/01 21:29:03 It's not needed for the image links, and I've take
Devlin 2016/11/05 04:56:09 You can do these via style - e.g. a { cursor: po
+ <img class="button-image" src="feedback.png" i18n-alt="sendFeedback">
+ </a>
+ </span>
+
+ <span id="status">&nbsp;</span>
+
+ <span id="options-button">
+ <a href="" id="options-link" class="image-link">
+ <img class="button-image" src="settings.png" i18n-alt="openOptions">
+ </a>
+ </span>
+ </div>
<script src="common.js"></script>
<script src="popup.js"></script>

Powered by Google App Engine
This is Rietveld 408576698