Chromium Code Reviews| Index: go-back-with-backspace/pages/options.css |
| diff --git a/go-back-with-backspace/pages/options.css b/go-back-with-backspace/pages/options.css |
| index 936a4613792c9834d1b9f4af67d80e84bc15b6cd..6ed264285d122aff0b19458e565cc5ff8be1d093 100644 |
| --- a/go-back-with-backspace/pages/options.css |
| +++ b/go-back-with-backspace/pages/options.css |
| @@ -5,37 +5,58 @@ |
| */ |
| body { |
| + background-color: #fff; |
| + margin: 0; |
| padding: 10px; |
| direction: __MSG_@@bidi_dir__; |
| } |
| textarea { |
| width: 100%; |
|
Devlin
2016/11/01 15:12:15
chromium-style: alphabetize these
|
| - margin: 0; |
| - padding: 0; |
| + margin-top: 2px; |
| + padding-__MSG_@@bidi_start_edge__: 4px; |
|
Devlin
2016/11/01 15:12:15
Why not use -webkit-padding variants?
Pam (message me for reviews)
2016/11/01 21:29:03
Because I didn't know about them. I'm only pretend
|
| +} |
| + |
| +input { |
| + margin-bottom: 20px; |
| +} |
| + |
| +fieldset { |
| + border: solid 1px #ccc; |
|
Devlin
2016/11/01 15:12:15
nit: looks like you have an extra space here?
|
| + border-radius: 3px; |
| + padding: 4px 8px; |
| } |
| -.applets { |
| - padding-top: 20px; |
| +fieldset legend { |
| + color: #036; |
|
Devlin
2016/11/01 15:12:15
optional nit: I don't know how much you want to fo
|
| } |
| -.whitelist { |
| - padding-top: 10px; |
| - padding-__MSG_@@bidi_start_edge__: 40px; |
| +.feedback-button { |
| + padding: 5px 0px 5px 0px; |
| + text-align: __MSG_@@bidi_end_edge__; |
|
Devlin
2016/11/01 15:12:15
why not 'end'?
Pam (message me for reviews)
2016/11/01 21:29:03
Because w3schools (the first hit for [css text-ali
|
| +} |
| + |
| +.setting { |
| + margin-top: 2px; |
| + margin-bottom: 2px; |
|
Devlin
2016/11/01 15:12:15
Why not margin: 2px 0;?
|
| +} |
| + |
| +.sub-setting { |
| + margin-top: 5px; |
| + margin-__MSG_@@bidi_start_edge__: 10px; |
| } |
| .buttons { |
| - padding-top: 2px; |
| - padding-bottom: 1px; |
| - padding-__MSG_@@bidi_start_edge__: 20px; |
| - padding-__MSG_@@bidi_end_edge__: 0px; |
| + margin-top: 2px; |
| + margin-bottom: 1px; |
| + margin-__MSG_@@bidi_start_edge__: 20px; |
| + margin-__MSG_@@bidi_end_edge__: 0px; |
| text-align: __MSG_@@bidi_end_edge__; |
| } |
| #error { |
| + margin-top: 5px; |
| + margin-bottom: 5px; |
|
Devlin
2016/11/01 15:12:15
margin: 5px 0;
|
| color: red; |
| } |
| -#report_page { |
| - float: __MSG_@@bidi_start_edge__; |
| -} |