Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: go-back-with-backspace/manifest.json

Issue 2400303003: Update UI and catch executeScript errors now shown in Canary (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go-back-with-backspace/background.js ('k') | go-back-with-backspace/pages/options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go-back-with-backspace/manifest.json
diff --git a/go-back-with-backspace/manifest.json b/go-back-with-backspace/manifest.json
index bd8308da115194fd9038a626a39cd49eb8383495..5726b8977902ee362fc85d0630078f026a128d45 100644
--- a/go-back-with-backspace/manifest.json
+++ b/go-back-with-backspace/manifest.json
@@ -35,6 +35,7 @@
"chrome_style": true
},
"permissions": [
+ "activeTab",
Pam (message me for reviews) 2016/10/07 23:12:43 It turns out this is needed after all, to get the
Devlin 2016/10/29 00:30:31 Sorry, don't follow - why is this needed? Which p
Pam (message me for reviews) 2016/10/29 05:10:36 The popup attached to the browser action, pages/po
Devlin 2016/11/01 15:12:14 That sounds like a bug to me. If you have all url
"management",
"storage",
"<all_urls>"
« no previous file with comments | « go-back-with-backspace/background.js ('k') | go-back-with-backspace/pages/options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698