Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /** | 1 /** |
| 2 * Copyright 2016 Google Inc. All rights reserved. | 2 * Copyright 2016 Google Inc. All rights reserved. |
| 3 * Use of this source code is governed by a BSD-style license that can be | 3 * Use of this source code is governed by a BSD-style license that can be |
| 4 * found in the LICENSE file. | 4 * found in the LICENSE file. |
| 5 */ | 5 */ |
| 6 | 6 |
| 7 body { | 7 body { |
| 8 background-color: #fff; | |
| 9 margin: 0; | |
| 8 padding: 10px; | 10 padding: 10px; |
| 9 direction: __MSG_@@bidi_dir__; | 11 direction: __MSG_@@bidi_dir__; |
| 10 } | 12 } |
| 11 | 13 |
| 12 textarea { | 14 textarea { |
| 13 width: 100%; | 15 width: 100%; |
|
Devlin
2016/11/01 15:12:15
chromium-style: alphabetize these
| |
| 14 margin: 0; | 16 margin-top: 2px; |
| 15 padding: 0; | 17 padding-__MSG_@@bidi_start_edge__: 4px; |
|
Devlin
2016/11/01 15:12:15
Why not use -webkit-padding variants?
Pam (message me for reviews)
2016/11/01 21:29:03
Because I didn't know about them. I'm only pretend
| |
| 16 } | 18 } |
| 17 | 19 |
| 18 .applets { | 20 input { |
| 19 padding-top: 20px; | 21 margin-bottom: 20px; |
| 20 } | 22 } |
| 21 | 23 |
| 22 .whitelist { | 24 fieldset { |
| 23 padding-top: 10px; | 25 border: solid 1px #ccc; |
|
Devlin
2016/11/01 15:12:15
nit: looks like you have an extra space here?
| |
| 24 padding-__MSG_@@bidi_start_edge__: 40px; | 26 border-radius: 3px; |
| 27 padding: 4px 8px; | |
| 28 } | |
| 29 | |
| 30 fieldset legend { | |
| 31 color: #036; | |
|
Devlin
2016/11/01 15:12:15
optional nit: I don't know how much you want to fo
| |
| 32 } | |
| 33 | |
| 34 .feedback-button { | |
| 35 padding: 5px 0px 5px 0px; | |
| 36 text-align: __MSG_@@bidi_end_edge__; | |
|
Devlin
2016/11/01 15:12:15
why not 'end'?
Pam (message me for reviews)
2016/11/01 21:29:03
Because w3schools (the first hit for [css text-ali
| |
| 37 } | |
| 38 | |
| 39 .setting { | |
| 40 margin-top: 2px; | |
| 41 margin-bottom: 2px; | |
|
Devlin
2016/11/01 15:12:15
Why not margin: 2px 0;?
| |
| 42 } | |
| 43 | |
| 44 .sub-setting { | |
| 45 margin-top: 5px; | |
| 46 margin-__MSG_@@bidi_start_edge__: 10px; | |
| 25 } | 47 } |
| 26 | 48 |
| 27 .buttons { | 49 .buttons { |
| 28 padding-top: 2px; | 50 margin-top: 2px; |
| 29 padding-bottom: 1px; | 51 margin-bottom: 1px; |
| 30 padding-__MSG_@@bidi_start_edge__: 20px; | 52 margin-__MSG_@@bidi_start_edge__: 20px; |
| 31 padding-__MSG_@@bidi_end_edge__: 0px; | 53 margin-__MSG_@@bidi_end_edge__: 0px; |
| 32 text-align: __MSG_@@bidi_end_edge__; | 54 text-align: __MSG_@@bidi_end_edge__; |
| 33 } | 55 } |
| 34 | 56 |
| 35 #error { | 57 #error { |
| 58 margin-top: 5px; | |
| 59 margin-bottom: 5px; | |
|
Devlin
2016/11/01 15:12:15
margin: 5px 0;
| |
| 36 color: red; | 60 color: red; |
| 37 } | 61 } |
| 38 | 62 |
| 39 #report_page { | |
| 40 float: __MSG_@@bidi_start_edge__; | |
| 41 } | |
| OLD | NEW |