Update UI and catch executeScript errors now shown in Canary

go-back-with-backspace/pages/common.js

 // Copyright 2016 Google Inc. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Load strings from messages.json into the HTML page. Each element that needs
 // an internationalized string should have an 'i18n' property holding the
-// name of the message to be used.
-function LoadInternationalizedStrings() {
+// name of the message to be used. If the element instead has an 'i18n-alt'
+// property, that message will be used for the alt and title attributes of the
+// element (generally an image).
+function loadInternationalizedStrings() {
   var all = document.querySelectorAll('[i18n]');
   for (var i = 0; i < all.length; ++i) {
     var i18n = all[i].getAttribute('i18n');
     if (i18n)
       all[i].textContent = chrome.i18n.getMessage(i18n);
   }
+
+  all = document.querySelectorAll('[i18n-alt]');
+  for (var i = 0; i < all.length; ++i) {
+    var i18n = all[i].getAttribute('i18n-alt');
+    if (i18n) {

[Devlin, 2016/11/01 15:12:14]

When is this falsey? (Same for line 14)

[Pam (message me for reviews), 2016/11/01 21:29:03]

Leftover from a past version, when it iterated over all nodes. Removed.

+      var message = chrome.i18n.getMessage(i18n);
+      all[i].alt = message;
+      all[i].title = message;
+    }
+  }
 }
 
 // Open a pre-filled email to send feedback to the extension developers. The
 // initial content of the email depends on whether the URL of the current page
 // is provided.
-function reportPage(url) {
+function sendFeedback(url) {
   var subject = chrome.i18n.getMessage('reportSubject');
   var body = '';
   if (url)
     body = chrome.i18n.getMessage('reportBodyWithURL', url);
   else
     body = chrome.i18n.getMessage('reportBody');
   var msg = 'mailto:gobackwithbackspace@google.com' +
       '?subject=' + encodeURIComponent(subject) +
       '&body=' + encodeURIComponent(body);
   chrome.tabs.create({
     url: msg,
     active: true});
 }