Add LwwRegister CRDT

blimp/net/helium/syncable_primitive_serializer.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/net/helium/syncable_primitive_serializer.h"
+
+#include <string>
+

[Kevin M, 2016/10/17 22:19:45]

stdint.h?

[steimel, 2016/10/18 23:53:20]

Done.

+#include "third_party/protobuf/src/google/protobuf/io/coded_stream.h"
+
+namespace blimp {
+
+void SyncablePrimitiveSerializer::Serialize(
+    const int32_t& value,
+    google::protobuf::io::CodedOutputStream* output_stream) {
+  output_stream->WriteVarint32((uint32_t)value);
+}

[Kevin M, 2016/10/17 22:19:45]

Add newline between methods and use comments to group methods instead,

e.g. 
// -----------------------------
// int32_t serialization methods

bool SyncablePr...

[steimel, 2016/10/18 23:53:20]

Done.

+bool SyncablePrimitiveSerializer::Deserialize(
+    google::protobuf::io::CodedInputStream* input_stream,
+    int32_t* value) {
+  return input_stream->ReadVarint32((uint32_t*)value);

[Kevin M, 2016/10/17 22:19:45]

Never use C-style casting. static_cast<> would work better here.

[steimel, 2016/10/18 23:53:20]

Done.

+}
+
+void SyncablePrimitiveSerializer::Serialize(
+    const std::string& value,
+    google::protobuf::io::CodedOutputStream* output_stream) {
+  output_stream->WriteVarint32(value.length());
+  output_stream->WriteString(value);
+}
+bool SyncablePrimitiveSerializer::Deserialize(
+    google::protobuf::io::CodedInputStream* input_stream,
+    std::string* value) {
+  uint32_t length;
+  if (input_stream->ReadVarint32(&length)) {

[Kevin M, 2016/10/17 22:19:45]

Should we have a sanity check of some sort here? It's obviously wrong if we get
a length that exceeds the maximum packet length, for example.

[steimel, 2016/10/18 23:53:20]

Done.

+    return input_stream->ReadString(value, length);
+  }
+  return false;
+}
+
+}  // namespace blimp