Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: blimp/helium/lww_register_unittest.cc

Issue 2400303002: Add LwwRegister CRDT (Closed)
Patch Set: Combine Bias and RunningAs enums, plus other code review feedback. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "blimp/helium/lww_register.h"
6
7 #include <string>
8
9 #include "blimp/helium/version_vector.h"
10 #include "blimp/helium/version_vector_generator.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12 #include "third_party/protobuf/src/google/protobuf/io/zero_copy_stream_impl_lite .h"
13
14 namespace blimp {
15 namespace helium {
16 namespace {
17
18 class LwwRegisterTest : public testing::Test {
19 protected:
20 void Initialize(Peer bias) {
21 bias_ = bias;
22 client_ =
23 base::MakeUnique<LwwRegister<int>>(&client_gen_, bias_, Peer::Client);
24 engine_ =
25 base::MakeUnique<LwwRegister<int>>(&engine_gen_, bias_, Peer::Engine);
26 }
27
28 void SyncFromClient() {
29 Sync(client_.get(), engine_.get(), engine_gen_.current(),
30 client_gen_.current());
31 }
32
33 void SyncFromEngine() {
34 Sync(engine_.get(), client_.get(), client_gen_.current(),
35 engine_gen_.current());
36 }
37
38 void Sync(LwwRegister<int>* from_lww_register,
39 LwwRegister<int>* to_lww_register,
40 VersionVector from,
41 VersionVector to);
42
43 VersionVectorGenerator client_gen_;
44 VersionVectorGenerator engine_gen_;
45
46 Peer bias_;
Kevin M 2016/10/19 17:49:11 Remove this field?
steimel 2016/10/20 00:30:07 Done.
47
48 std::unique_ptr<LwwRegister<int>> client_;
49 std::unique_ptr<LwwRegister<int>> engine_;
50 };
Kevin M 2016/10/19 17:49:11 DISALLOW_COPY_AND_ASSIGN
steimel 2016/10/20 00:30:07 Done.
51
52 // Takes a changeset from |from_lww_register| and applies it to
53 // |to_lww_register|.
54 void LwwRegisterTest::Sync(LwwRegister<int>* from_lww_register,
55 LwwRegister<int>* to_lww_register,
56 VersionVector from,
57 VersionVector to) {
58 // Create a changeset from |from_lww_register|.
59 std::string changeset;
60 google::protobuf::io::StringOutputStream raw_output_stream(&changeset);
61 google::protobuf::io::CodedOutputStream output_stream(&raw_output_stream);
62 from_lww_register->CreateChangesetToCurrent(from.Invert(), &output_stream);
scf 2016/10/19 17:23:03 do you need to invert here? i thought it was just
steimel 2016/10/19 17:37:54 Yep. |from| comes from |to_lww_register|, and so i
63
64 // Apply the changeset to |to_lww_register|.
65 google::protobuf::io::ArrayInputStream raw_input_stream(changeset.data(),
66 changeset.size());
67 google::protobuf::io::CodedInputStream input_stream(&raw_input_stream);
68 to_lww_register->ApplyChangeset(from, to.Invert(), &input_stream);
69 }
70
71 TEST_F(LwwRegisterTest, SetIncrementsLocalVersion) {
72 Initialize(Peer::Client);
73
74 VersionVector earlier_version = client_gen_.current();
75 client_->Set(42);
76 VersionVector current_version = client_gen_.current();
77
78 EXPECT_EQ(42, client_->Get());
79 EXPECT_LT(earlier_version.local_revision(), current_version.local_revision());
80 EXPECT_TRUE(client_->ModifiedSince(earlier_version));
81 EXPECT_FALSE(client_->ModifiedSince(current_version));
82 }
83
84 TEST_F(LwwRegisterTest, ApplyLaterChangeset) {
85 Initialize(Peer::Client);
86
87 client_->Set(123);
88 SyncFromClient();
89
90 EXPECT_EQ(123, engine_->Get());
91 }
92
93 TEST_F(LwwRegisterTest, ApplyEarlierChangeset) {
94 Initialize(Peer::Client);
95
96 client_->Set(123);
97 SyncFromClient();
98
99 engine_->Set(456);
100 SyncFromClient();
101
102 EXPECT_EQ(456, engine_->Get());
103 }
104
105 TEST_F(LwwRegisterTest, ClientApplyChangesetConflictClientWins) {
106 Initialize(Peer::Client);
107
108 client_->Set(123);
109 engine_->Set(456);
110 SyncFromEngine();
111
112 EXPECT_EQ(123, client_->Get());
113 }
114
115 TEST_F(LwwRegisterTest, EngineApplyChangesetConflictClientWins) {
116 Initialize(Peer::Client);
117
118 client_->Set(123);
119 engine_->Set(456);
120 SyncFromClient();
121
122 EXPECT_EQ(123, engine_->Get());
123 }
124
125 TEST_F(LwwRegisterTest, ClientApplyChangesetConflictEngineWins) {
126 Initialize(Peer::Engine);
127
128 client_->Set(123);
129 engine_->Set(456);
130 SyncFromEngine();
131
132 EXPECT_EQ(456, client_->Get());
133 }
134
135 TEST_F(LwwRegisterTest, EngineApplyChangesetConflictEngineWins) {
136 Initialize(Peer::Engine);
137
138 client_->Set(123);
139 engine_->Set(456);
140 SyncFromClient();
141
142 EXPECT_EQ(456, engine_->Get());
143 }
144
Kevin M 2016/10/19 17:49:11 Clean tests!
steimel 2016/10/20 00:30:07 Thanks!
145 } // namespace
146 } // namespace helium
147 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698