Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2400273002: Revert of Switching from CLD3 to CLD2 (Closed)

Created:
4 years, 2 months ago by Anton Bakalov
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, groby-ooo-7-16, djweiss1, riesa
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switching from CLD3 to CLD2 (patchset #1 id:1 of https://codereview.chromium.org/2396183002/ ) Reason for revert: We created this CL, so that we can merge it into M54 and switch from CLD3 to CLD2. I am reverting it now to continue testing CLD3 in M55. Original issue's description: > Switching from CLD3 to CLD2 > > This is accomplished by: > - flipping the flag in third_party/cld/BUILD.gn > - listing explicitly source files in third_party/cld_2/BUILD.gn that > were originally retrieved from the following gyp file which got > removed during the transition away from GYP: > https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp > > BUG=653881 > > Committed: https://crrev.com/13cff7269b9e76b0f77ecb94eade1dfee02e6a32 > Cr-Commit-Position: refs/heads/master@{#423855} TBR=brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653881 Committed: https://crrev.com/ac2066d0dd39fd8d282617a8ab9416b91c773e61 Cr-Commit-Position: refs/heads/master@{#423895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -56 lines) Patch
M third_party/cld/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld_2/BUILD.gn View 3 chunks +9 lines, -55 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Anton Bakalov
Created Revert of Switching from CLD3 to CLD2
4 years, 2 months ago (2016-10-07 17:14:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400273002/1
4 years, 2 months ago (2016-10-07 17:14:53 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-07 17:14:55 UTC) #5
brettw
lgtm
4 years, 2 months ago (2016-10-07 17:22:37 UTC) #6
Anton Bakalov
On 2016/10/07 17:22:37, brettw (ping on IM after 24h) wrote: > lgtm Thanks a lot ...
4 years, 2 months ago (2016-10-07 17:24:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400273002/1
4 years, 2 months ago (2016-10-07 17:24:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 17:25:21 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 17:27:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac2066d0dd39fd8d282617a8ab9416b91c773e61
Cr-Commit-Position: refs/heads/master@{#423895}

Powered by Google App Engine
This is Rietveld 408576698