Reland of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation

Reland of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation (patchset #1 id:1 of https://codereview.chromium.org/2396393002/ )

Reason for revert:
Still flakes after this revert, relanding.

Original issue's description:
> Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation (patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )
>
> Reason for revert:
> This is a speculative revert...
>
> Two tests started failing somewhat reliably on Win7 in the build where this was checked in and all the other CLs in that build look completely unrelated.
>
> NavigatingExtensionPopupBrowserTest.DownloadViaPost
> PageLoadMetricsBrowserTest.IgnoreDownloads
>
> https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests
>
> I've actually already disabled the NavigatingExtensionPopupBrowserTest in a separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this revert then we can undo the revert.
>
> Original issue's description:
> > Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> >
> > If a URL request is cancelled by a requester, there's a chance on
> > URLResponseBodyConsumer to run OnReadable() on an invalid
> > ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> > access.
> >
> > This CL clears the URLLoaderClient earlier in the cancellation phase to
> > avoid the crash.
> >
> > BUG=603396
> >
> > Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> > Cr-Commit-Position: refs/heads/master@{#423779}
>
> TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=603396
>
> Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
> Cr-Commit-Position: refs/heads/master@{#423868}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org,nasko@chromium.org,kinuko@chromium.org,lukasza@chromium.org,finnur@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
Committed: https://crrev.com/4c55a1b55ff37c8ea5832a99282f8683ccd22f45
Cr-Commit-Position: refs/heads/master@{#423887}

[gab, 2016-10-07 16:56:20]

The CQ bit was checked by gab@chromium.org

[gab, 2016-10-07 16:56:20]

Created Reland of Clear mojo URLLoaderClient in ResourceDispatcher on
cancellation

[commit-bot: I haz the power, 2016-10-07 16:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 16:57:32]

Description was changed from

==========
Reland of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #1 id:1 of https://codereview.chromium.org/2396393002/ )

Reason for revert:
Still flakes after this revert, relanding.

Original issue's description:
> Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )
> 
> Reason for revert:
> This is a speculative revert...
> 
> Two tests started failing somewhat reliably on Win7 in the build where this
was checked in and all the other CLs in that build look completely unrelated.
> 
> NavigatingExtensionPopupBrowserTest.DownloadViaPost
> PageLoadMetricsBrowserTest.IgnoreDownloads
> 
> https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests
> 
> I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.
> 
> Original issue's description:
> > Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> >
> > If a URL request is cancelled by a requester, there's a chance on
> > URLResponseBodyConsumer to run OnReadable() on an invalid
> > ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> > access.
> >
> > This CL clears the URLLoaderClient earlier in the cancellation phase to
> > avoid the crash.
> >
> > BUG=603396
> >
> > Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> > Cr-Commit-Position: refs/heads/master@{#423779}
> 
> TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=603396
> 
> Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
> Cr-Commit-Position: refs/heads/master@{#423868}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org,nasko@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

to

==========
Reland of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #1 id:1 of https://codereview.chromium.org/2396393002/ )

Reason for revert:
Still flakes after this revert, relanding.

Original issue's description:
> Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )
> 
> Reason for revert:
> This is a speculative revert...
> 
> Two tests started failing somewhat reliably on Win7 in the build where this
was checked in and all the other CLs in that build look completely unrelated.
> 
> NavigatingExtensionPopupBrowserTest.DownloadViaPost
> PageLoadMetricsBrowserTest.IgnoreDownloads
> 
> https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests
> 
> I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.
> 
> Original issue's description:
> > Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> >
> > If a URL request is cancelled by a requester, there's a chance on
> > URLResponseBodyConsumer to run OnReadable() on an invalid
> > ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> > access.
> >
> > This CL clears the URLLoaderClient earlier in the cancellation phase to
> > avoid the crash.
> >
> > BUG=603396
> >
> > Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> > Cr-Commit-Position: refs/heads/master@{#423779}
> 
> TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=603396
> 
> Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
> Cr-Commit-Position: refs/heads/master@{#423868}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org,nasko@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

[commit-bot: I haz the power, 2016-10-07 16:57:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 16:59:58]

Description was changed from

==========
Reland of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #1 id:1 of https://codereview.chromium.org/2396393002/ )

Reason for revert:
Still flakes after this revert, relanding.

Original issue's description:
> Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )
> 
> Reason for revert:
> This is a speculative revert...
> 
> Two tests started failing somewhat reliably on Win7 in the build where this
was checked in and all the other CLs in that build look completely unrelated.
> 
> NavigatingExtensionPopupBrowserTest.DownloadViaPost
> PageLoadMetricsBrowserTest.IgnoreDownloads
> 
> https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests
> 
> I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.
> 
> Original issue's description:
> > Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> >
> > If a URL request is cancelled by a requester, there's a chance on
> > URLResponseBodyConsumer to run OnReadable() on an invalid
> > ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> > access.
> >
> > This CL clears the URLLoaderClient earlier in the cancellation phase to
> > avoid the crash.
> >
> > BUG=603396
> >
> > Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> > Cr-Commit-Position: refs/heads/master@{#423779}
> 
> TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=603396
> 
> Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
> Cr-Commit-Position: refs/heads/master@{#423868}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org,nasko@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396
==========

to

==========
Reland of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #1 id:1 of https://codereview.chromium.org/2396393002/ )

Reason for revert:
Still flakes after this revert, relanding.

Original issue's description:
> Revert of Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
(patchset #2 id:20001 of https://codereview.chromium.org/2399463002/ )
>
> Reason for revert:
> This is a speculative revert...
>
> Two tests started failing somewhat reliably on Win7 in the build where this
was checked in and all the other CLs in that build look completely unrelated.
>
> NavigatingExtensionPopupBrowserTest.DownloadViaPost
> PageLoadMetricsBrowserTest.IgnoreDownloads
>
> https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests
>
> I've actually already disabled the NavigatingExtensionPopupBrowserTest in a
separate CL, but if the PageLoadMetricsBrowserTest doesn't get fixed with this
revert then we can undo the revert.
>
> Original issue's description:
> > Clear mojo URLLoaderClient in ResourceDispatcher on cancellation
> >
> > If a URL request is cancelled by a requester, there's a chance on
> > URLResponseBodyConsumer to run OnReadable() on an invalid
> > ResourceDispatcher::PendingRequestInfo. That causes a null pointer
> > access.
> >
> > This CL clears the URLLoaderClient earlier in the cancellation phase to
> > avoid the crash.
> >
> > BUG=603396
> >
> > Committed: https://crrev.com/bc1ffa6150628c6ddb8ae3cf51b8e9d0e965f1a4
> > Cr-Commit-Position: refs/heads/master@{#423779}
>
> TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=603396
>
> Committed: https://crrev.com/f99b117244d8e8e0a9ca0e7ad775a98e77c94f9c
> Cr-Commit-Position: refs/heads/master@{#423868}

TBR=yhirano@chromium.org,jam@chromium.org,tzik@chromium.org,nasko@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=603396

Committed: https://crrev.com/4c55a1b55ff37c8ea5832a99282f8683ccd22f45
Cr-Commit-Position: refs/heads/master@{#423887}
==========

[commit-bot: I haz the power, 2016-10-07 16:59:59]

Patchset 1 (id:??) landed as
https://crrev.com/4c55a1b55ff37c8ea5832a99282f8683ccd22f45
Cr-Commit-Position: refs/heads/master@{#423887}