Remove grow box rect support, browser part.

Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
TBR=rsesek

Committed: https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb
Cr-Commit-Position: refs/heads/master@{#423920}

[Nico, 2016-10-07 16:13:19]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-07 16:18:30]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:18:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-07 16:30:17]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-07 16:42:07]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:42:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-07 16:44:07]

Description was changed from

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also. (XXX check if current
macOS's even have that method still)

BUG=653271
==========

to

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
==========

[Nico, 2016-10-07 16:45:05]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 16:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-07 16:55:44]

thakis@chromium.org changed reviewers:
+ avi@chromium.org, ben@chromium.org

[Nico, 2016-10-07 16:55:44]

ben: services (removes an uncalled function)
avi: rest

[commit-bot: I haz the power, 2016-10-07 17:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 17:26:54]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-07 17:32:26]

lgtm

[Ben Goodger (Google), 2016-10-07 17:48:07]

lgtm

[Nico, 2016-10-07 18:28:59]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:40:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-10-07 18:45:02]

Description was changed from

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
==========

to

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
TBR=rsesek
==========

[Nico, 2016-10-07 18:45:32]

thakis@chromium.org changed reviewers:
+ rsesek@chromium.org

[Nico, 2016-10-07 18:45:33]

Thanks!

TBR=rsesek for view.mojo SECURITY_OWNERS (just removing a method, which seems
pretty safe)

[Nico, 2016-10-07 18:45:38]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:46:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Robert Sesek, 2016-10-07 18:47:47]

On 2016/10/07 18:45:33, Nico wrote:
> Thanks!
> 
> TBR=rsesek for view.mojo SECURITY_OWNERS (just removing a method, which seems
> pretty safe)

Please do not TBR SECURITY_OWNERS.

[Robert Sesek, 2016-10-07 18:48:36]

But LGTM :)

[Nico, 2016-10-07 18:48:37]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-10-07 18:48:37]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:49:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-10-07 18:49:07]

On 2016/10/07 18:47:47, Robert Sesek wrote:
> On 2016/10/07 18:45:33, Nico wrote:
> > Thanks!
> > 
> > TBR=rsesek for view.mojo SECURITY_OWNERS (just removing a method, which
seems
> > pretty safe)
> 
> Please do not TBR SECURITY_OWNERS.

For deleting messages? When is that ever unsafe?

[Robert Sesek, 2016-10-07 18:52:49]

On 2016/10/07 18:49:07, Nico wrote:
> On 2016/10/07 18:47:47, Robert Sesek wrote:
> > On 2016/10/07 18:45:33, Nico wrote:
> > > Thanks!
> > > 
> > > TBR=rsesek for view.mojo SECURITY_OWNERS (just removing a method, which
> seems
> > > pretty safe)
> > 
> > Please do not TBR SECURITY_OWNERS.
> 
> For deleting messages? 

Yes. The pool of SECURITY_OWNERS is deliberately large to not cause significant
latency.

> When is that ever unsafe?

Things like:
bool CanINavigateHereSafely(GURL url)
ParsedValue ParseContentOOP(string input)

[Nico, 2016-10-07 19:09:10]

On Fri, Oct 7, 2016 at 2:52 PM, <rsesek@chromium.org> wrote:

> On 2016/10/07 18:49:07, Nico wrote:
> > On 2016/10/07 18:47:47, Robert Sesek wrote:
> > > On 2016/10/07 18:45:33, Nico wrote:
> > > > Thanks!
> > > >
> > > > TBR=rsesek for view.mojo SECURITY_OWNERS (just removing a method,
> which
> > seems
> > > > pretty safe)
> > >
> > > Please do not TBR SECURITY_OWNERS.
> >
> > For deleting messages?
>
> Yes. The pool of SECURITY_OWNERS is deliberately large to not cause
> significant
> latency.
>
> > When is that ever unsafe?
>
> Things like:
> bool CanINavigateHereSafely(GURL url)
> ParsedValue ParseContentOOP(string input)
>

Good point, thanks!

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-10-07 19:10:18]

Description was changed from

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
TBR=rsesek
==========

to

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
==========

[commit-bot: I haz the power, 2016-10-07 19:10:34]

Description was changed from

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
==========

to

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
==========

[commit-bot: I haz the power, 2016-10-07 19:10:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-07 19:12:02]

Description was changed from

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
==========

to

==========
Remove grow box rect support, browser part.

We added all this grow box rect plumbing for macOS, but 10.6 was the
last version with grow boxes, and we no longer suport that.  Views
never sets this to anything other than (0, 0, 0, 0), and on macOS
we use whatever [NSWindow _growBoxRect] returns -- on macOS versions
newer than 10.6, that's always (0, 0, 0, 0) also, even if "always show
scrollbars" is checked in System Preferences (but the method
_growBoxRect still exists as of 10.11)

BUG=653271
TBR=rsesek

Committed: https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb
Cr-Commit-Position: refs/heads/master@{#423920}
==========

[commit-bot: I haz the power, 2016-10-07 19:12:03]

Patchset 5 (id:??) landed as
https://crrev.com/4c77f96d88caa76e1200e5dab191215000fda7cb
Cr-Commit-Position: refs/heads/master@{#423920}