Handlify HashTable and Dictionary growing.

Handlify HashTable and Dictionary growing.

R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20820

[Dmitry Lomov (no reviews), 2014-04-16 16:38:51]

PTAL. Almost all uses, except a couple (StringTable and PolymorphicCodeCache)
that need separate CLs

[Igor Sheludko, 2014-04-16 17:58:55]

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7976
src/objects.cc:7976: Handle<FixedArray> AsHandle() {
AsObject() method is quite simple, consider handlifying it as well.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7987
src/objects.cc:7987: Handle<Code> code_;
You should use MaybeHandle<> here as the code could be null. The one of the
goals is to remove Handle::is_null() completely.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7991
src/objects.cc:7991: Object* CodeCacheHashTable::Lookup(Name* name, Code::Flags
flags) {
You are calling handlified code from non-handlified which is not safe in
general. In this case it seems to be safe, so please put an
DisallowHeapAllocation scope here.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode8003
src/objects.cc:8003: // Don't use |this|, as the table might have grown.
I think this comment is obsolete now.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode8016
src/objects.cc:8016: int CodeCacheHashTable::GetIndex(Name* name, Code::Flags
flags) {
Add DisallowHeapAllocation scope.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode14793
src/objects.cc:14793: 
Add one more empty line here.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode15746
src/objects.cc:15746: Object* MapCache::Lookup(FixedArray* array) {
Add DisallowHeapAllocation scope.

[Dmitry Lomov (no reviews), 2014-04-16 18:07:57]

Comments addressed, PTAL.

[Igor Sheludko, 2014-04-16 18:12:42]

lgtm

[Dmitry Lomov (no reviews), 2014-04-16 18:14:37]

Sorry, comments were lost - adding them

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7976
src/objects.cc:7976: Handle<FixedArray> AsHandle() {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> AsObject() method is quite simple, consider handlifying it as well.
AsObject() itself is a part of HashTable key contract, so can't be handlified.
I could duplicate the logic in AsHandle but I prefer not to duplicate the logic.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7987
src/objects.cc:7987: Handle<Code> code_;
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> You should use MaybeHandle<> here as the code could be null. The one of the
> goals is to remove Handle::is_null() completely.

Done.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7991
src/objects.cc:7991: Object* CodeCacheHashTable::Lookup(Name* name, Code::Flags
flags) {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> You are calling handlified code from non-handlified which is not safe in
> general. In this case it seems to be safe, so please put an
> DisallowHeapAllocation scope here.

Done.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode8003
src/objects.cc:8003: // Don't use |this|, as the table might have grown.
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> I think this comment is obsolete now.

Done.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode8016
src/objects.cc:8016: int CodeCacheHashTable::GetIndex(Name* name, Code::Flags
flags) {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> Add DisallowHeapAllocation scope.

Done.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode14793
src/objects.cc:14793: 
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> Add one more empty line here.

Done.

https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode15746
src/objects.cc:15746: Object* MapCache::Lookup(FixedArray* array) {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
> Add DisallowHeapAllocation scope.

Done.

[Dmitry Lomov (no reviews), 2014-04-16 18:17:40]

Committed patchset #3 manually as r20820 (presubmit successful).