Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 240023003: Further enhancements to command_line frontend to memory_inspector (Closed)

Created:
6 years, 8 months ago by paulwhitton
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@memory-inspector-cli-enhancements
Visibility:
Public.

Description

Further enhancements to command_line frontend to memory_inspector Print memory maps for a process Print consolidated memory map data for a process BUG=340294 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265655

Patch Set 1 #

Total comments: 6

Patch Set 2 : Changes following review #

Total comments: 9

Patch Set 3 : Changes following review #

Total comments: 4

Patch Set 4 : Further changes following review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -75 lines) Patch
M tools/memory_inspector/memory_inspector/frontends/command_line.py View 1 2 3 4 chunks +94 lines, -74 lines 0 comments Download
M tools/memory_inspector/memory_inspector_cli View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
paulwhitton
Hi Primiano, Please can you review my changes to the memory inspector command line. Cheers ...
6 years, 8 months ago (2014-04-16 11:54:20 UTC) #1
Primiano Tucci (use gerrit)
Thanks Paul, just a couple of comments, but looks in good shape. Ah another thing: ...
6 years, 8 months ago (2014-04-16 12:54:54 UTC) #2
paulwhitton
Hi Primiano, Please can you review the changes I have made following your review. Cheers ...
6 years, 8 months ago (2014-04-22 10:55:55 UTC) #3
Primiano Tucci (use gerrit)
On 2014/04/22 10:55:55, paulwhitton wrote: > Hi Primiano, > > Please can you review the ...
6 years, 8 months ago (2014-04-22 11:24:47 UTC) #4
Primiano Tucci (use gerrit)
THanks Paul. Looks in good shape, but there is some extra code it might be ...
6 years, 8 months ago (2014-04-22 13:08:48 UTC) #5
paulwhitton
Hi Primiano, Please can you review my further changes. Cheers Paul
6 years, 8 months ago (2014-04-23 15:28:21 UTC) #6
Primiano Tucci (use gerrit)
LGTM with few nits. Please take a look to the comments and update the CL ...
6 years, 8 months ago (2014-04-23 15:36:57 UTC) #7
paulwhitton
The CQ bit was checked by paulwhitton@google.com
6 years, 8 months ago (2014-04-23 15:53:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/paulwhitton@google.com/240023003/60001
6 years, 8 months ago (2014-04-23 15:53:45 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 15:54:43 UTC) #10
Message was sent while issue was closed.
Change committed as 265655

Powered by Google App Engine
This is Rietveld 408576698