Add UMA metrics to OffscreenCanvas's commit type

Add UMA metrics to OffscreenCanvas's commit type

When OffscreenCanvas's commit happens, it has 4 possible modes with the
combination of disable/enable accelerated-2d-canvas and disable/enable
gpu compositing. This CL tracks the usage of each mode.

BUG=653599
Committed: https://crrev.com/3d42d4419ac50ee39c9ec5c2d99296f094de80d8
Cr-Commit-Position: refs/heads/master@{#424664}

[xidachen, 2016-10-07 15:09:07]

xidachen@chromium.org changed reviewers:
+ isherman@chromium.org, junov@chromium.org

[xidachen, 2016-10-07 15:09:08]

PTAL

[Justin Novosad, 2016-10-07 15:19:50]

On 2016/10/07 15:09:08, xidachen wrote:
> PTAL

lgtm for WebKit

[Ilya Sherman, 2016-10-11 00:54:11]

https://codereview.chromium.org/2400223002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
(right):

https://codereview.chromium.org/2400223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h:40:
enum OffscreenCanvasCommitType {
Please document that this enum is used to back an UMA histogram, and should
therefore be treated as append-only.

https://codereview.chromium.org/2400223002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2400223002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:38969: +<histogram
name="OffscreenCanvas.CommitType" enum="OffscreenCanvasCommitType">
It looks like you're adding a new top-level group, "OffscreenCanvas".  Could you
please find an existing top-level group that would be appropriate for this
histogram?  Or are you convinced that there aren't any such groups?

For example, I would suggest "Canvas.Offscreen.CommitType".

[xidachen, 2016-10-11 17:21:16]

https://codereview.chromium.org/2400223002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
(right):

https://codereview.chromium.org/2400223002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h:40:
enum OffscreenCanvasCommitType {
On 2016/10/11 00:54:11, Ilya Sherman wrote:
> Please document that this enum is used to back an UMA histogram, and should
> therefore be treated as append-only.

Done.

https://codereview.chromium.org/2400223002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2400223002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:38969: +<histogram
name="OffscreenCanvas.CommitType" enum="OffscreenCanvasCommitType">
On 2016/10/11 00:54:11, Ilya Sherman wrote:
> It looks like you're adding a new top-level group, "OffscreenCanvas".  Could
you
> please find an existing top-level group that would be appropriate for this
> histogram?  Or are you convinced that there aren't any such groups?
> 
> For example, I would suggest "Canvas.Offscreen.CommitType".

Done.

[Ilya Sherman, 2016-10-11 23:50:28]

histograms lgtm, thanks

[xidachen, 2016-10-12 01:48:31]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 01:48:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xidachen, 2016-10-12 02:27:05]

The CQ bit was unchecked by xidachen@chromium.org

[xidachen, 2016-10-12 02:27:47]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-10-12 02:27:47]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2400223002/#ps40001
(title: "rebase + address comments")

[commit-bot: I haz the power, 2016-10-12 02:27:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 03:56:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-12 03:58:20]

Description was changed from

==========
Add UMA metrics to OffscreenCanvas's commit type

When OffscreenCanvas's commit happens, it has 4 possible modes with the
combination of disable/enable accelerated-2d-canvas and disable/enable
gpu compositing. This CL tracks the usage of each mode.

BUG=653599
==========

to

==========
Add UMA metrics to OffscreenCanvas's commit type

When OffscreenCanvas's commit happens, it has 4 possible modes with the
combination of disable/enable accelerated-2d-canvas and disable/enable
gpu compositing. This CL tracks the usage of each mode.

BUG=653599

Committed: https://crrev.com/3d42d4419ac50ee39c9ec5c2d99296f094de80d8
Cr-Commit-Position: refs/heads/master@{#424664}
==========

[commit-bot: I haz the power, 2016-10-12 03:58:22]

Patchset 3 (id:??) landed as
https://crrev.com/3d42d4419ac50ee39c9ec5c2d99296f094de80d8
Cr-Commit-Position: refs/heads/master@{#424664}