Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4582)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2400213003: [Offline Pages] Fix several infobar bugs. (Closed)
Patch Set: Address dfalcantara's & qinmin's feedback. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
index 5a52c519349420db2d0afc226c66ee5b6cb3c29b..541fc9b9b1a0f7953674054614f426b2ac58ce6f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
@@ -7,9 +7,11 @@ package org.chromium.chrome.browser.offlinepages.downloads;
import android.content.ComponentName;
import android.support.annotation.Nullable;
+import org.chromium.base.ContextUtils;
import org.chromium.base.ObserverList;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.chrome.R;
import org.chromium.chrome.browser.download.DownloadItem;
import org.chromium.chrome.browser.download.DownloadServiceDelegate;
import org.chromium.chrome.browser.download.ui.BackendProvider.OfflinePageDelegate;
@@ -196,7 +198,8 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli
* @param tab a tab contents of which will be saved locally.
*/
public void startDownload(Tab tab) {
- nativeStartDownload(mNativeOfflinePageDownloadBridge, tab);
+ nativeStartDownload(mNativeOfflinePageDownloadBridge, tab,
+ ContextUtils.getApplicationContext().getString(R.string.menu_downloads));
}
/**
@@ -283,5 +286,6 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli
native void nativeResumeDownload(long nativeOfflinePageDownloadBridge, String guid);
native void nativeDeleteItemByGuid(long nativeOfflinePageDownloadBridge, String guid);
native long nativeGetOfflineIdByGuid(long nativeOfflinePageDownloadBridge, String guid);
- native void nativeStartDownload(long nativeOfflinePageDownloadBridge, Tab tab);
+ native void nativeStartDownload(
+ long nativeOfflinePageDownloadBridge, Tab tab, String downloadsLabel);
}

Powered by Google App Engine
This is Rietveld 408576698