chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h - Issue 2400213003: [Offline Pages] Fix several infobar bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

Issue 2400213003: [Offline Pages] Fix several infobar bugs. (Closed)

Patch Set: git cl web Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java ('k') | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc » ('j') | chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

diff --git a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

index 0f9b5a445fb2ed64038b934982e1f971a981c2ab..b2f938fb76b54f2395de01dc2c828b2c65c31afa 100644

--- a/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

+++ b/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

@@ -61,7 +61,8 @@ class OfflinePageDownloadBridge : public DownloadUIAdapter::Observer {

void StartDownload(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,

- const base::android::JavaParamRef<jobject>& j_tab);

+ const base::android::JavaParamRef<jobject>& j_tab,

+ const base::android::JavaParamRef<jstring>& j_downloads_string);

Dmitry Titov 2016/10/10 18:26:56 on Java side you had a better name for it, downloa

void CancelDownload(JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj,