Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2400203002: [Interpreter] Remove an invalid DCHECK. (Closed)

Created:
4 years, 2 months ago by rmcilroy
Modified:
4 years, 2 months ago
Reviewers:
mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove an invalid DCHECK. A wide jump can be patched with a non-wide jump target operand, so the DCHECK added in r39637 was wrong. BUG=chromium:652430 Committed: https://crrev.com/2c9b5844f982172aaa978563b557275fdf82f8c2 Cr-Commit-Position: refs/heads/master@{#40090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/interpreter/bytecode-array-writer.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rmcilroy
PTAL, thanks.
4 years, 2 months ago (2016-10-07 14:08:15 UTC) #4
mythria
lgtm.
4 years, 2 months ago (2016-10-07 14:39:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400203002/1
4 years, 2 months ago (2016-10-07 14:51:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:55:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:55:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c9b5844f982172aaa978563b557275fdf82f8c2
Cr-Commit-Position: refs/heads/master@{#40090}

Powered by Google App Engine
This is Rietveld 408576698