Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: net/test/ct_test_util.cc

Issue 2400183002: Cleanup: More accurate output parameter type for CTVerifier (Closed)
Patch Set: IWYU, review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/ct_test_util.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/ct_test_util.cc
diff --git a/net/test/ct_test_util.cc b/net/test/ct_test_util.cc
index c8b25f88ddf521e6f75c09e1ade82b8abf2a9cc5..f9862e0cc6000cffd797349df5cb748c8bc6a1fb 100644
--- a/net/test/ct_test_util.cc
+++ b/net/test/ct_test_util.cc
@@ -397,16 +397,16 @@ std::string GetSCTListWithInvalidSCT() {
return sct_list;
}
-bool CheckForSingleVerifiedSCTInResult(const ct::CTVerifyResult& result,
- const std::string& log_description) {
- return (result.scts.size() == 1 &&
- result.scts[0].status == ct::SCT_STATUS_OK &&
- result.scts[0].sct->log_description == log_description);
+bool CheckForSingleVerifiedSCTInResult(
+ const SignedCertificateTimestampAndStatusList& scts,
+ const std::string& log_description) {
+ return (scts.size() == 1 && scts[0].status == ct::SCT_STATUS_OK &&
+ scts[0].sct->log_description == log_description);
}
-bool CheckForSCTOrigin(const ct::CTVerifyResult& result,
+bool CheckForSCTOrigin(const SignedCertificateTimestampAndStatusList& scts,
ct::SignedCertificateTimestamp::Origin origin) {
- for (const auto& sct_and_status : result.scts)
+ for (const auto& sct_and_status : scts)
if (sct_and_status.status == SCT_STATUS_OK &&
sct_and_status.sct->origin == origin)
return true;
« no previous file with comments | « net/test/ct_test_util.h ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698