Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: net/url_request/url_request_unittest.cc

Issue 2400183002: Cleanup: More accurate output parameter type for CTVerifier (Closed)
Patch Set: IWYU, review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/test/ct_test_util.cc ('k') | remoting/protocol/ssl_hmac_channel_authenticator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 #include "net/base/net_errors.h" 54 #include "net/base/net_errors.h"
55 #include "net/base/net_module.h" 55 #include "net/base/net_module.h"
56 #include "net/base/request_priority.h" 56 #include "net/base/request_priority.h"
57 #include "net/base/upload_bytes_element_reader.h" 57 #include "net/base/upload_bytes_element_reader.h"
58 #include "net/base/upload_data_stream.h" 58 #include "net/base/upload_data_stream.h"
59 #include "net/base/upload_file_element_reader.h" 59 #include "net/base/upload_file_element_reader.h"
60 #include "net/base/url_util.h" 60 #include "net/base/url_util.h"
61 #include "net/cert/ct_policy_enforcer.h" 61 #include "net/cert/ct_policy_enforcer.h"
62 #include "net/cert/ct_policy_status.h" 62 #include "net/cert/ct_policy_status.h"
63 #include "net/cert/ct_verifier.h" 63 #include "net/cert/ct_verifier.h"
64 #include "net/cert/ct_verify_result.h"
65 #include "net/cert/ev_root_ca_metadata.h" 64 #include "net/cert/ev_root_ca_metadata.h"
66 #include "net/cert/mock_cert_verifier.h" 65 #include "net/cert/mock_cert_verifier.h"
66 #include "net/cert/signed_certificate_timestamp_and_status.h"
67 #include "net/cert/test_root_certs.h" 67 #include "net/cert/test_root_certs.h"
68 #include "net/cert_net/nss_ocsp.h" 68 #include "net/cert_net/nss_ocsp.h"
69 #include "net/cookies/cookie_monster.h" 69 #include "net/cookies/cookie_monster.h"
70 #include "net/cookies/cookie_store_test_helpers.h" 70 #include "net/cookies/cookie_store_test_helpers.h"
71 #include "net/disk_cache/disk_cache.h" 71 #include "net/disk_cache/disk_cache.h"
72 #include "net/dns/mock_host_resolver.h" 72 #include "net/dns/mock_host_resolver.h"
73 #include "net/http/http_byte_range.h" 73 #include "net/http/http_byte_range.h"
74 #include "net/http/http_cache.h" 74 #include "net/http/http_cache.h"
75 #include "net/http/http_network_layer.h" 75 #include "net/http/http_network_layer.h"
76 #include "net/http/http_network_session.h" 76 #include "net/http/http_network_session.h"
(...skipping 6294 matching lines...) Expand 10 before | Expand all | Expand 10 after
6371 6371
6372 // A CTVerifier that returns net::OK for every certificate. 6372 // A CTVerifier that returns net::OK for every certificate.
6373 class MockCTVerifier : public CTVerifier { 6373 class MockCTVerifier : public CTVerifier {
6374 public: 6374 public:
6375 MockCTVerifier() {} 6375 MockCTVerifier() {}
6376 ~MockCTVerifier() override {} 6376 ~MockCTVerifier() override {}
6377 6377
6378 int Verify(X509Certificate* cert, 6378 int Verify(X509Certificate* cert,
6379 const std::string& stapled_ocsp_response, 6379 const std::string& stapled_ocsp_response,
6380 const std::string& sct_list_from_tls_extension, 6380 const std::string& sct_list_from_tls_extension,
6381 ct::CTVerifyResult* result, 6381 SignedCertificateTimestampAndStatusList* output_scts,
6382 const NetLogWithSource& net_log) override { 6382 const NetLogWithSource& net_log) override {
6383 return net::OK; 6383 return net::OK;
6384 } 6384 }
6385 6385
6386 void SetObserver(Observer* observer) override {} 6386 void SetObserver(Observer* observer) override {}
6387 }; 6387 };
6388 6388
6389 // A CTPolicyEnforcer that returns a default CertPolicyCompliance value 6389 // A CTPolicyEnforcer that returns a default CertPolicyCompliance value
6390 // for every certificate. 6390 // for every certificate.
6391 class MockCTPolicyEnforcer : public CTPolicyEnforcer { 6391 class MockCTPolicyEnforcer : public CTPolicyEnforcer {
(...skipping 3825 matching lines...) Expand 10 before | Expand all | Expand 10 after
10217 AddTestInterceptor()->set_main_intercept_job(std::move(job)); 10217 AddTestInterceptor()->set_main_intercept_job(std::move(job));
10218 10218
10219 req->Start(); 10219 req->Start();
10220 req->Cancel(); 10220 req->Cancel();
10221 base::RunLoop().RunUntilIdle(); 10221 base::RunLoop().RunUntilIdle();
10222 EXPECT_EQ(ERR_ABORTED, d.request_status()); 10222 EXPECT_EQ(ERR_ABORTED, d.request_status());
10223 EXPECT_EQ(0, d.received_redirect_count()); 10223 EXPECT_EQ(0, d.received_redirect_count());
10224 } 10224 }
10225 10225
10226 } // namespace net 10226 } // namespace net
OLDNEW
« no previous file with comments | « net/test/ct_test_util.cc ('k') | remoting/protocol/ssl_hmac_channel_authenticator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698