Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Side by Side Diff: net/socket/ssl_client_socket_unittest.cc

Issue 2400183002: Cleanup: More accurate output parameter type for CTVerifier (Closed)
Patch Set: IWYU, review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/socket/ssl_client_socket_impl.cc ('k') | net/socket/ssl_server_socket_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/ssl_client_socket.h" 5 #include "net/socket/ssl_client_socket.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <utility> 10 #include <utility>
(...skipping 14 matching lines...) Expand all
25 #include "crypto/scoped_openssl_types.h" 25 #include "crypto/scoped_openssl_types.h"
26 #include "net/base/address_list.h" 26 #include "net/base/address_list.h"
27 #include "net/base/io_buffer.h" 27 #include "net/base/io_buffer.h"
28 #include "net/base/net_errors.h" 28 #include "net/base/net_errors.h"
29 #include "net/base/test_completion_callback.h" 29 #include "net/base/test_completion_callback.h"
30 #include "net/cert/asn1_util.h" 30 #include "net/cert/asn1_util.h"
31 #include "net/cert/ct_policy_enforcer.h" 31 #include "net/cert/ct_policy_enforcer.h"
32 #include "net/cert/ct_policy_status.h" 32 #include "net/cert/ct_policy_status.h"
33 #include "net/cert/ct_verifier.h" 33 #include "net/cert/ct_verifier.h"
34 #include "net/cert/mock_cert_verifier.h" 34 #include "net/cert/mock_cert_verifier.h"
35 #include "net/cert/signed_certificate_timestamp_and_status.h"
35 #include "net/cert/test_root_certs.h" 36 #include "net/cert/test_root_certs.h"
36 #include "net/der/input.h" 37 #include "net/der/input.h"
37 #include "net/der/parser.h" 38 #include "net/der/parser.h"
38 #include "net/der/tag.h" 39 #include "net/der/tag.h"
39 #include "net/dns/host_resolver.h" 40 #include "net/dns/host_resolver.h"
40 #include "net/http/transport_security_state.h" 41 #include "net/http/transport_security_state.h"
41 #include "net/log/net_log_event_type.h" 42 #include "net/log/net_log_event_type.h"
42 #include "net/log/net_log_source.h" 43 #include "net/log/net_log_source.h"
43 #include "net/log/test_net_log.h" 44 #include "net/log/test_net_log.h"
44 #include "net/log/test_net_log_entry.h" 45 #include "net/log/test_net_log_entry.h"
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 }; 700 };
700 701
701 // A mock CTVerifier that records every call to Verify but doesn't verify 702 // A mock CTVerifier that records every call to Verify but doesn't verify
702 // anything. 703 // anything.
703 class MockCTVerifier : public CTVerifier { 704 class MockCTVerifier : public CTVerifier {
704 public: 705 public:
705 MOCK_METHOD5(Verify, 706 MOCK_METHOD5(Verify,
706 int(X509Certificate*, 707 int(X509Certificate*,
707 const std::string&, 708 const std::string&,
708 const std::string&, 709 const std::string&,
709 ct::CTVerifyResult*, 710 SignedCertificateTimestampAndStatusList*,
710 const NetLogWithSource&)); 711 const NetLogWithSource&));
711 MOCK_METHOD1(SetObserver, void(CTVerifier::Observer*)); 712 MOCK_METHOD1(SetObserver, void(CTVerifier::Observer*));
712 }; 713 };
713 714
714 // A mock CTPolicyEnforcer that returns a custom verification result. 715 // A mock CTPolicyEnforcer that returns a custom verification result.
715 class MockCTPolicyEnforcer : public CTPolicyEnforcer { 716 class MockCTPolicyEnforcer : public CTPolicyEnforcer {
716 public: 717 public:
717 MOCK_METHOD3(DoesConformToCertPolicy, 718 MOCK_METHOD3(DoesConformToCertPolicy,
718 ct::CertPolicyCompliance(X509Certificate* cert, 719 ct::CertPolicyCompliance(X509Certificate* cert,
719 const ct::SCTList&, 720 const ct::SCTList&,
(...skipping 2950 matching lines...) Expand 10 before | Expand all | Expand 10 after
3670 // Replace it with an alert. 3671 // Replace it with an alert.
3671 raw_transport->ReplaceReadResult( 3672 raw_transport->ReplaceReadResult(
3672 FormatTLS12Alert(49 /* AlertDescription.access_denied */)); 3673 FormatTLS12Alert(49 /* AlertDescription.access_denied */));
3673 raw_transport->UnblockReadResult(); 3674 raw_transport->UnblockReadResult();
3674 3675
3675 rv = callback.GetResult(rv); 3676 rv = callback.GetResult(rv);
3676 EXPECT_THAT(rv, IsError(ERR_BAD_SSL_CLIENT_AUTH_CERT)); 3677 EXPECT_THAT(rv, IsError(ERR_BAD_SSL_CLIENT_AUTH_CERT));
3677 } 3678 }
3678 3679
3679 } // namespace net 3680 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_impl.cc ('k') | net/socket/ssl_server_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698