Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: net/cert/multi_log_ct_verifier.h

Issue 2400183002: Cleanup: More accurate output parameter type for CTVerifier (Closed)
Patch Set: IWYU, review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/ct_verifier.h ('k') | net/cert/multi_log_ct_verifier.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_MULTI_LOG_CT_VERIFIER_H_ 5 #ifndef NET_CERT_MULTI_LOG_CT_VERIFIER_H_
6 #define NET_CERT_MULTI_LOG_CT_VERIFIER_H_ 6 #define NET_CERT_MULTI_LOG_CT_VERIFIER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 19 matching lines...) Expand all
30 MultiLogCTVerifier(); 30 MultiLogCTVerifier();
31 ~MultiLogCTVerifier() override; 31 ~MultiLogCTVerifier() override;
32 32
33 void AddLogs( 33 void AddLogs(
34 const std::vector<scoped_refptr<const CTLogVerifier>>& log_verifiers); 34 const std::vector<scoped_refptr<const CTLogVerifier>>& log_verifiers);
35 35
36 // CTVerifier implementation: 36 // CTVerifier implementation:
37 int Verify(X509Certificate* cert, 37 int Verify(X509Certificate* cert,
38 const std::string& stapled_ocsp_response, 38 const std::string& stapled_ocsp_response,
39 const std::string& sct_list_from_tls_extension, 39 const std::string& sct_list_from_tls_extension,
40 ct::CTVerifyResult* result, 40 SignedCertificateTimestampAndStatusList* output_scts,
41 const NetLogWithSource& net_log) override; 41 const NetLogWithSource& net_log) override;
42 42
43 void SetObserver(Observer* observer) override; 43 void SetObserver(Observer* observer) override;
44 44
45 private: 45 private:
46 // Verify a list of SCTs from |encoded_sct_list| over |expected_entry|, 46 // Verify a list of SCTs from |encoded_sct_list| over |expected_entry|,
47 // placing the verification results in |result|. The SCTs in the list 47 // placing the verification results in |result|. The SCTs in the list
48 // come from |origin| (as will be indicated in the origin field of each SCT). 48 // come from |origin| (as will be indicated in the origin field of each SCT).
49 bool VerifySCTs(const std::string& encoded_sct_list, 49 bool VerifySCTs(const std::string& encoded_sct_list,
50 const ct::LogEntry& expected_entry, 50 const ct::LogEntry& expected_entry,
51 ct::SignedCertificateTimestamp::Origin origin, 51 ct::SignedCertificateTimestamp::Origin origin,
52 X509Certificate* cert, 52 X509Certificate* cert,
53 ct::CTVerifyResult* result); 53 SignedCertificateTimestampAndStatusList* output_scts);
54 54
55 // Verifies a single, parsed SCT against all logs. 55 // Verifies a single, parsed SCT against all logs.
56 bool VerifySingleSCT(scoped_refptr<ct::SignedCertificateTimestamp> sct, 56 bool VerifySingleSCT(scoped_refptr<ct::SignedCertificateTimestamp> sct,
57 const ct::LogEntry& expected_entry, 57 const ct::LogEntry& expected_entry,
58 X509Certificate* cert, 58 X509Certificate* cert,
59 ct::CTVerifyResult* result); 59 SignedCertificateTimestampAndStatusList* output_scts);
60 60
61 // Mapping from a log's ID to the verifier for this log. 61 // Mapping from a log's ID to the verifier for this log.
62 // A log's ID is the SHA-256 of the log's key, as defined in section 3.2. 62 // A log's ID is the SHA-256 of the log's key, as defined in section 3.2.
63 // of RFC6962. 63 // of RFC6962.
64 std::map<std::string, scoped_refptr<const CTLogVerifier>> logs_; 64 std::map<std::string, scoped_refptr<const CTLogVerifier>> logs_;
65 65
66 Observer* observer_; 66 Observer* observer_;
67 67
68 DISALLOW_COPY_AND_ASSIGN(MultiLogCTVerifier); 68 DISALLOW_COPY_AND_ASSIGN(MultiLogCTVerifier);
69 }; 69 };
70 70
71 } // namespace net 71 } // namespace net
72 72
73 #endif // NET_CERT_MULTI_LOG_CT_VERIFIER_H_ 73 #endif // NET_CERT_MULTI_LOG_CT_VERIFIER_H_
OLDNEW
« no previous file with comments | « net/cert/ct_verifier.h ('k') | net/cert/multi_log_ct_verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698