Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2400173003: [MD Feedback] Add feedback to closure compiler. (Closed)

Created:
4 years, 2 months ago by apacible
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Feedback] Add feedback to closure compiler. BUG=606844 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b26ca18ee488e669952885ace34da241890fb42c Cr-Commit-Position: refs/heads/master@{#424367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
A + chrome/browser/resources/md_feedback/compiled_resources2.gyp View 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_feedback/feedback.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/closure_compiler/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
apacible
PTAL, thanks!
4 years, 2 months ago (2016-10-07 20:32:48 UTC) #6
Dan Beam
lgtm
4 years, 2 months ago (2016-10-11 00:13:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400173003/1
4 years, 2 months ago (2016-10-11 03:27:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 04:22:27 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 04:25:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b26ca18ee488e669952885ace34da241890fb42c
Cr-Commit-Position: refs/heads/master@{#424367}

Powered by Google App Engine
This is Rietveld 408576698