arc: enable Android tracing in verified-boot mode

chrome/browser/chromeos/arc/trace/arc_trace_bridge.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/arc/trace/arc_trace_bridge.h"
+
+#include <sys/socket.h>
+#include <sys/types.h>
+
+#include <utility>
+
+#include "base/bind.h"
+#include "base/logging.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "components/arc/arc_bridge_service.h"
+#include "components/arc/arc_service_manager.h"
+#include "content/public/browser/browser_thread.h"
+
+#include "mojo/edk/embedder/embedder.h"
+#include "mojo/edk/embedder/scoped_platform_handle.h"
+#include "mojo/public/cpp/system/platform_handle.h"
+
+namespace arc {
+
+namespace {
+
+// The prefix of the categories to be shown on the trace selection UI.
+constexpr char kCategoryPrefix[] = TRACE_DISABLED_BY_DEFAULT("android ");
+
+}  // namespace
+
+ArcTraceBridge::ArcTraceBridge(ArcBridgeService* bridge_service)
+    : ArcService(bridge_service), weak_ptr_factory_(this) {
+  arc_bridge_service()->trace()->AddObserver(this);
+  chromeos::ArcTraceAgent::GetInstance()->SetDelegate(this);
+}
+
+ArcTraceBridge::~ArcTraceBridge() {
+  chromeos::ArcTraceAgent::GetInstance()->SetDelegate(nullptr);
+  arc_bridge_service()->trace()->RemoveObserver(this);
+}
+
+void ArcTraceBridge::OnInstanceReady() {

[Luis Héctor Chávez, 2017/02/10 17:43:54]

nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

[Earl Ou, 2017/03/22 11:38:25]

Done.

+  int fds[2];
+  int ret = socketpair(AF_UNIX, SOCK_SEQPACKET, 0, fds);
+  DCHECK_EQ(0, ret);

[Luis Héctor Chávez, 2017/02/10 17:43:54]

this will be messy on non-debug builds since you'll pass garbage as fds to the
rest of the system.

It's better to replace this with/add:

if (ret < 0) {
  LOG(ERROR) << "...";
  return;
}

[Earl Ou, 2017/03/22 11:38:26]

Done in arc_tracing_agent.cc now.

+
+  auto* trace_instance =
+      ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->trace(), SetHostSocket);
+  if (!trace_instance)
+    return;
+
+  mojo::ScopedHandle handle = mojo::WrapPlatformFile(fds[1]);
+  trace_instance->SetHostSocket(std::move(handle));

[Luis Héctor Chávez, 2017/02/10 17:43:54]

nit: trace_instance->SetHostSocket(mojo::WrapPlatformFile(fds[1]));

seems to be more readable and still fits.

[Earl Ou, 2017/03/22 11:38:26]

Done.

+  reader_.SetInputFD(base::ScopedFD(fds[0]));
+
+  QueryAvailableCategories();
+}
+
+void ArcTraceBridge::QueryAvailableCategories() {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  auto* trace_instance = ARC_GET_INSTANCE_FOR_METHOD(
+      arc_bridge_service()->trace(), QueryAvailableCategories);
+  if (!trace_instance)
+    return;
+  trace_instance->QueryAvailableCategories(base::Bind(
+      &ArcTraceBridge::OnCategoriesReady, weak_ptr_factory_.GetWeakPtr()));
+}
+
+void ArcTraceBridge::OnCategoriesReady(
+    const std::vector<std::string>& categories) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  categories_.clear();
+  for (const auto& category : categories) {
+    categories_.push_back(

[Luis Héctor Chávez, 2017/02/10 17:43:54]

nit: you can use emplace_back() here.

[Earl Ou, 2017/03/22 11:38:25]

Done.

+        Category{category, std::string(kCategoryPrefix) + category});
+    // Show the category name in the selection UI.
+    base::trace_event::TraceLog::GetCategoryGroupEnabled(
+        categories_.back().full_name.c_str());
+  }
+}
+
+void ArcTraceBridge::StartTracing(
+    const base::trace_event::TraceConfig& trace_config,
+    const StartTracingCallback& callback) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  auto* trace_instance =
+      ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->trace(), StartTracing);
+  if (!trace_instance) {
+    // Use PostTask as the convention of TraceAgent. The caller expects
+    // callback to be called after this function returns.
+    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+                                                  base::Bind(callback, false));
+    return;
+  }
+
+  std::vector<std::string> selected_categories;
+  for (const auto& category : categories_) {
+    if (trace_config.IsCategoryGroupEnabled(category.full_name.c_str()))
+      selected_categories.push_back(category.name);
+  }
+
+  reader_.StartRecord();
+  trace_instance->StartTracing(selected_categories, callback);
+}
+
+void ArcTraceBridge::StopTracing(const StopTracingCallback& callback) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  auto* trace_instance =
+      ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->trace(), StopTracing);
+  if (!trace_instance) {
+    reader_.StopRecord(callback);
+    return;
+  }
+  trace_instance->StopTracing(base::Bind(&ArcTraceBridge::OnStopTracing,
+                                         weak_ptr_factory_.GetWeakPtr(),
+                                         callback));
+}
+
+void ArcTraceBridge::OnStopTracing(const StopTracingCallback& callback,
+                                   bool success) {
+  if (!success) {
+    LOG(WARNING) << "Failed to stop tracing in ARC.";

[Luis Héctor Chávez, 2017/02/10 17:43:54]

nit: LOG_IF(WARNING, !success) << "...";

[Earl Ou, 2017/03/22 11:38:25]

Done.

+  }
+  reader_.StopRecord(callback);
+}
+
+}  // namespace arc