Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 2400163003: arc: enable Android tracing in verified-boot mode (Closed)
Patch Set: Fix according to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "content/browser/tracing/tracing_controller_impl.h" 4 #include "content/browser/tracing/tracing_controller_impl.h"
5 5
6 #include <algorithm>
7 #include <memory>
8 #include <utility>
9
6 #include "base/bind.h" 10 #include "base/bind.h"
7 #include "base/cpu.h" 11 #include "base/cpu.h"
8 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
9 #include "base/guid.h" 13 #include "base/guid.h"
10 #include "base/json/string_escape.h" 14 #include "base/json/string_escape.h"
11 #include "base/macros.h" 15 #include "base/macros.h"
12 #include "base/memory/ref_counted_memory.h" 16 #include "base/memory/ref_counted_memory.h"
13 #include "base/strings/string_number_conversions.h" 17 #include "base/strings/string_number_conversions.h"
14 #include "base/sys_info.h" 18 #include "base/sys_info.h"
15 #include "base/threading/thread_task_runner_handle.h" 19 #include "base/threading/thread_task_runner_handle.h"
(...skipping 19 matching lines...) Expand all
35 #if (defined(OS_POSIX) && defined(USE_UDEV)) || defined(OS_WIN) || \ 39 #if (defined(OS_POSIX) && defined(USE_UDEV)) || defined(OS_WIN) || \
36 defined(OS_MACOSX) 40 defined(OS_MACOSX)
37 #define ENABLE_POWER_TRACING 41 #define ENABLE_POWER_TRACING
38 #endif 42 #endif
39 43
40 #if defined(ENABLE_POWER_TRACING) 44 #if defined(ENABLE_POWER_TRACING)
41 #include "content/browser/tracing/power_tracing_agent.h" 45 #include "content/browser/tracing/power_tracing_agent.h"
42 #endif 46 #endif
43 47
44 #if defined(OS_CHROMEOS) 48 #if defined(OS_CHROMEOS)
49 #include "chromeos/dbus/arc_trace_agent.h"
45 #include "chromeos/dbus/dbus_thread_manager.h" 50 #include "chromeos/dbus/dbus_thread_manager.h"
46 #include "chromeos/dbus/debug_daemon_client.h" 51 #include "chromeos/dbus/debug_daemon_client.h"
47 #endif 52 #endif
48 53
49 #if defined(OS_WIN) 54 #if defined(OS_WIN)
50 #include "content/browser/tracing/etw_tracing_agent_win.h" 55 #include "content/browser/tracing/etw_tracing_agent_win.h"
51 #endif 56 #endif
52 57
53 using base::trace_event::TraceLog; 58 using base::trace_event::TraceLog;
54 using base::trace_event::TraceConfig; 59 using base::trace_event::TraceConfig;
55 60
56 namespace content { 61 namespace content {
57 62
58 namespace { 63 namespace {
59 64
60 base::LazyInstance<TracingControllerImpl>::Leaky g_controller = 65 base::LazyInstance<TracingControllerImpl>::Leaky g_controller =
61 LAZY_INSTANCE_INITIALIZER; 66 LAZY_INSTANCE_INITIALIZER;
62 67
63 const char kChromeTracingAgentName[] = "chrome"; 68 const char kChromeTracingAgentName[] = "chrome";
64 const char kETWTracingAgentName[] = "etw"; 69 const char kETWTracingAgentName[] = "etw";
70 const char kArcTracingAgentName[] = "arc";
65 const char kChromeTraceLabel[] = "traceEvents"; 71 const char kChromeTraceLabel[] = "traceEvents";
66 72
67 const int kStartTracingTimeoutSeconds = 30; 73 const int kStartTracingTimeoutSeconds = 30;
68 const int kIssueClockSyncTimeoutSeconds = 30; 74 const int kIssueClockSyncTimeoutSeconds = 30;
69 const int kStopTracingRetryTimeMilliseconds = 100; 75 const int kStopTracingRetryTimeMilliseconds = 100;
70 76
71 std::string GetNetworkTypeString() { 77 std::string GetNetworkTypeString() {
72 switch (net::NetworkChangeNotifier::GetConnectionType()) { 78 switch (net::NetworkChangeNotifier::GetConnectionType()) {
73 case net::NetworkChangeNotifier::CONNECTION_ETHERNET: 79 case net::NetworkChangeNotifier::CONNECTION_ETHERNET:
74 return "Ethernet"; 80 return "Ethernet";
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 } 296 }
291 #elif defined(OS_WIN) 297 #elif defined(OS_WIN)
292 EtwTracingAgent::GetInstance()->StartAgentTracing( 298 EtwTracingAgent::GetInstance()->StartAgentTracing(
293 trace_config, 299 trace_config,
294 base::Bind(&TracingControllerImpl::OnStartAgentTracingAcked, 300 base::Bind(&TracingControllerImpl::OnStartAgentTracingAcked,
295 base::Unretained(this))); 301 base::Unretained(this)));
296 ++pending_start_tracing_ack_count_; 302 ++pending_start_tracing_ack_count_;
297 #endif 303 #endif
298 } 304 }
299 305
306 #if defined(OS_CHROMEOS)
307 auto* arc_trace_agent =
308 chromeos::DBusThreadManager::Get()->GetArcTraceAgent();
309 if (arc_trace_agent) {
310 arc_trace_agent->StartAgentTracing(
311 trace_config,
312 base::Bind(&TracingControllerImpl::OnStartAgentTracingAcked,
313 base::Unretained(this)));
314 ++pending_start_tracing_ack_count_;
315 }
316 #endif
317
300 // TraceLog may have been enabled in startup tracing before threads are ready. 318 // TraceLog may have been enabled in startup tracing before threads are ready.
301 if (TraceLog::GetInstance()->IsEnabled()) 319 if (TraceLog::GetInstance()->IsEnabled())
302 return true; 320 return true;
303 321
304 StartAgentTracing(trace_config, 322 StartAgentTracing(trace_config,
305 base::Bind(&TracingControllerImpl::OnStartAgentTracingAcked, 323 base::Bind(&TracingControllerImpl::OnStartAgentTracingAcked,
306 base::Unretained(this))); 324 base::Unretained(this)));
307 ++pending_start_tracing_ack_count_; 325 ++pending_start_tracing_ack_count_;
308 326
309 // Set a deadline to ensure all agents ack within a reasonable time frame. 327 // Set a deadline to ensure all agents ack within a reasonable time frame.
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
555 void TracingControllerImpl::AddTracingAgent(const std::string& agent_name) { 573 void TracingControllerImpl::AddTracingAgent(const std::string& agent_name) {
556 #if defined(OS_CHROMEOS) 574 #if defined(OS_CHROMEOS)
557 auto* debug_daemon = 575 auto* debug_daemon =
558 chromeos::DBusThreadManager::Get()->GetDebugDaemonClient(); 576 chromeos::DBusThreadManager::Get()->GetDebugDaemonClient();
559 if (agent_name == debug_daemon->GetTracingAgentName()) { 577 if (agent_name == debug_daemon->GetTracingAgentName()) {
560 additional_tracing_agents_.push_back(debug_daemon); 578 additional_tracing_agents_.push_back(debug_daemon);
561 debug_daemon->SetStopAgentTracingTaskRunner( 579 debug_daemon->SetStopAgentTracingTaskRunner(
562 BrowserThread::GetBlockingPool()); 580 BrowserThread::GetBlockingPool());
563 return; 581 return;
564 } 582 }
583
584 auto* arc_trace_agent =
585 chromeos::DBusThreadManager::Get()->GetArcTraceAgent();
586 if (arc_trace_agent && agent_name == arc_trace_agent->GetTracingAgentName()) {
587 additional_tracing_agents_.push_back(arc_trace_agent);
588 arc_trace_agent->SetStopAgentTracingTaskRunner(
589 BrowserThread::GetBlockingPool());
590 return;
591 }
565 #elif defined(OS_WIN) 592 #elif defined(OS_WIN)
566 auto* etw_agent = EtwTracingAgent::GetInstance(); 593 auto* etw_agent = EtwTracingAgent::GetInstance();
567 if (agent_name == etw_agent->GetTracingAgentName()) { 594 if (agent_name == etw_agent->GetTracingAgentName()) {
568 additional_tracing_agents_.push_back(etw_agent); 595 additional_tracing_agents_.push_back(etw_agent);
569 return; 596 return;
570 } 597 }
571 #endif 598 #endif
572 599
573 #if defined(ENABLE_POWER_TRACING) 600 #if defined(ENABLE_POWER_TRACING)
574 auto* power_agent = PowerTracingAgent::GetInstance(); 601 auto* power_agent = PowerTracingAgent::GetInstance();
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 687
661 void TracingControllerImpl::OnEndAgentTracingAcked( 688 void TracingControllerImpl::OnEndAgentTracingAcked(
662 const std::string& agent_name, 689 const std::string& agent_name,
663 const std::string& events_label, 690 const std::string& events_label,
664 const scoped_refptr<base::RefCountedString>& events_str_ptr) { 691 const scoped_refptr<base::RefCountedString>& events_str_ptr) {
665 DCHECK_CURRENTLY_ON(BrowserThread::UI); 692 DCHECK_CURRENTLY_ON(BrowserThread::UI);
666 693
667 if (trace_data_sink_.get() && events_str_ptr && 694 if (trace_data_sink_.get() && events_str_ptr &&
668 !events_str_ptr->data().empty()) { 695 !events_str_ptr->data().empty()) {
669 std::string json_string; 696 std::string json_string;
670 if (agent_name == kETWTracingAgentName) { 697 if (agent_name == kETWTracingAgentName ||
671 // The Windows kernel events are kept into a JSON format stored as string 698 agent_name == kArcTracingAgentName) {
672 // and must not be escaped. 699 // The Windows kernel events and ARC Android tracing event are kept
700 // into a JSON format stored as string and must not be escaped.
673 json_string = events_str_ptr->data(); 701 json_string = events_str_ptr->data();
674 } else { 702 } else {
675 json_string = base::GetQuotedJSONString(events_str_ptr->data()); 703 json_string = base::GetQuotedJSONString(events_str_ptr->data());
676 } 704 }
677 trace_data_sink_->AddAgentTrace(events_label, json_string); 705
706 if (agent_name == kArcTracingAgentName) {
707 trace_data_sink_->AddTraceChunk(json_string);
708 } else {
709 trace_data_sink_->AddAgentTrace(events_label, json_string);
710 }
678 } 711 }
679 std::vector<std::string> category_groups; 712 std::vector<std::string> category_groups;
680 OnStopTracingAcked(NULL, category_groups); 713 OnStopTracingAcked(NULL, category_groups);
681 } 714 }
682 715
683 void TracingControllerImpl::OnTraceDataCollected( 716 void TracingControllerImpl::OnTraceDataCollected(
684 const scoped_refptr<base::RefCountedString>& events_str_ptr) { 717 const scoped_refptr<base::RefCountedString>& events_str_ptr) {
685 // OnTraceDataCollected may be called from any browser thread, either by the 718 // OnTraceDataCollected may be called from any browser thread, either by the
686 // local event trace system or from child processes via TraceMessageFilter. 719 // local event trace system or from child processes via TraceMessageFilter.
687 if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) { 720 if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 void TracingControllerImpl::RecordClockSyncMarker( 855 void TracingControllerImpl::RecordClockSyncMarker(
823 const std::string& sync_id, 856 const std::string& sync_id,
824 const RecordClockSyncMarkerCallback& callback) { 857 const RecordClockSyncMarkerCallback& callback) {
825 DCHECK(SupportsExplicitClockSync()); 858 DCHECK(SupportsExplicitClockSync());
826 859
827 TRACE_EVENT_CLOCK_SYNC_RECEIVER(sync_id); 860 TRACE_EVENT_CLOCK_SYNC_RECEIVER(sync_id);
828 } 861 }
829 862
830 void TracingControllerImpl::IssueClockSyncMarker() { 863 void TracingControllerImpl::IssueClockSyncMarker() {
831 DCHECK_CURRENTLY_ON(BrowserThread::UI); 864 DCHECK_CURRENTLY_ON(BrowserThread::UI);
832 DCHECK(pending_clock_sync_ack_count_ == 0); 865 DCHECK_EQ(pending_clock_sync_ack_count_, 0);
Yusuke Sato 2017/01/04 23:55:48 DCHECK_EQ(0, ...);
833 866
834 for (auto* it : additional_tracing_agents_) { 867 for (auto* it : additional_tracing_agents_) {
835 if (it->SupportsExplicitClockSync()) { 868 if (it->SupportsExplicitClockSync()) {
836 it->RecordClockSyncMarker( 869 it->RecordClockSyncMarker(
837 base::GenerateGUID(), 870 base::GenerateGUID(),
838 base::Bind(&TracingControllerImpl::OnClockSyncMarkerRecordedByAgent, 871 base::Bind(&TracingControllerImpl::OnClockSyncMarkerRecordedByAgent,
839 base::Unretained(this))); 872 base::Unretained(this)));
840 pending_clock_sync_ack_count_++; 873 pending_clock_sync_ack_count_++;
841 } 874 }
842 } 875 }
(...skipping 19 matching lines...) Expand all
862 // success indicator instead of having to rely on sentinel issue_ts and 895 // success indicator instead of having to rely on sentinel issue_ts and
863 // issue_end_ts values to signal failure. 896 // issue_end_ts values to signal failure.
864 if (!(issue_ts == base::TimeTicks() || issue_end_ts == base::TimeTicks())) 897 if (!(issue_ts == base::TimeTicks() || issue_end_ts == base::TimeTicks()))
865 TRACE_EVENT_CLOCK_SYNC_ISSUER(sync_id, issue_ts, issue_end_ts); 898 TRACE_EVENT_CLOCK_SYNC_ISSUER(sync_id, issue_ts, issue_end_ts);
866 899
867 // Timer is not running means that clock sync already timed out. 900 // Timer is not running means that clock sync already timed out.
868 if (!clock_sync_timer_.IsRunning()) 901 if (!clock_sync_timer_.IsRunning())
869 return; 902 return;
870 903
871 // Stop tracing only if all agents report back. 904 // Stop tracing only if all agents report back.
872 if(--pending_clock_sync_ack_count_ == 0) { 905 if (--pending_clock_sync_ack_count_ == 0) {
873 clock_sync_timer_.Stop(); 906 clock_sync_timer_.Stop();
874 StopTracingAfterClockSync(); 907 StopTracingAfterClockSync();
875 } 908 }
876 } 909 }
877 910
878 void TracingControllerImpl::AddFilteredMetadata( 911 void TracingControllerImpl::AddFilteredMetadata(
879 TracingController::TraceDataSink* sink, 912 TracingController::TraceDataSink* sink,
880 std::unique_ptr<base::DictionaryValue> metadata, 913 std::unique_ptr<base::DictionaryValue> metadata,
881 const MetadataFilterPredicate& filter) { 914 const MetadataFilterPredicate& filter) {
882 if (filter.is_null()) { 915 if (filter.is_null()) {
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1060 // Schedule the next queued dump (if applicable). 1093 // Schedule the next queued dump (if applicable).
1061 if (!queued_memory_dump_requests_.empty()) { 1094 if (!queued_memory_dump_requests_.empty()) {
1062 BrowserThread::PostTask( 1095 BrowserThread::PostTask(
1063 BrowserThread::UI, FROM_HERE, 1096 BrowserThread::UI, FROM_HERE,
1064 base::Bind(&TracingControllerImpl::PerformNextQueuedGlobalMemoryDump, 1097 base::Bind(&TracingControllerImpl::PerformNextQueuedGlobalMemoryDump,
1065 base::Unretained(this))); 1098 base::Unretained(this)));
1066 } 1099 }
1067 } 1100 }
1068 1101
1069 } // namespace content 1102 } // namespace content
OLDNEW
« components/arc/common/trace.mojom ('K') | « components/arc/common/trace.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698