Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Side by Side Diff: chrome/browser/chromeos/arc/trace/arc_trace_bridge.cc

Issue 2400163003: arc: enable Android tracing in verified-boot mode (Closed)
Patch Set: Fix according to review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/chromeos/arc/trace/arc_trace_bridge.h"
6
7 #include <utility>
8
9 #include "base/logging.h"
10 #include "components/arc/arc_bridge_service.h"
11 #include "components/arc/arc_service_manager.h"
12
13 namespace arc {
14
15 namespace {
16
17 // This class is owned by ArcServiceManager so that it is safe to use this raw
18 // pointer as the singleton reference.
19 ArcTraceBridge* g_arc_trace_bridge = nullptr;
20
21 // The prefix of the categories to be shown on the trace selection UI.
22 constexpr char kCategoryPrefix[] = TRACE_DISABLED_BY_DEFAULT("android ");
23
24 } // namcespace
Luis Héctor Chávez 2016/12/27 19:15:58 nit: s/namcespace/namespace/
shunhsingou 2016/12/28 09:15:15 Done.
25
26 ArcTraceBridge* ArcTraceBridge::Get() {
27 return g_arc_trace_bridge;
28 }
29
30 ArcTraceBridge::ArcTraceBridge(ArcBridgeService* bridge_service)
31 : ArcService(bridge_service), weak_ptr_factory_(this) {
32 arc_bridge_service()->trace()->AddObserver(this);
33 g_arc_trace_bridge = this;
Luis Héctor Chávez 2016/12/27 19:15:58 DCHECK(!g_arc_trace_bridge);
shunhsingou 2016/12/28 09:15:15 Done.
34 }
35
36 ArcTraceBridge::~ArcTraceBridge() {
37 arc_bridge_service()->trace()->RemoveObserver(this);
38 g_arc_trace_bridge = nullptr;
39 }
40
41 void ArcTraceBridge::OnInstanceReady() {
42 QueryAvailableCategories();
43 }
44
45 void ArcTraceBridge::QueryAvailableCategories() {
46 auto* trace_instance = arc_bridge_service()->trace()->GetInstanceForMethod(
47 "QueryAvailableCategories");
48 if (!trace_instance)
49 return;
50 trace_instance->QueryAvailableCategories(base::Bind(
51 &ArcTraceBridge::OnCategoriesReady, weak_ptr_factory_.GetWeakPtr()));
52 }
53
54 void ArcTraceBridge::OnCategoriesReady(
55 const std::vector<std::string>& categories) {
56 DCHECK(thread_checker_.CalledOnValidThread());
57
Luis Héctor Chávez 2016/12/27 19:15:58 Do you need |categories_.clear();| here?
shunhsingou 2016/12/28 09:15:15 Done.
58 for (const auto& category : categories) {
59 categories_.push_back(
60 Category{category, std::string(kCategoryPrefix) + category});
61 // Show the category name in the selection UI.
62 base::trace_event::TraceLog::GetCategoryGroupEnabled(
63 categories_.back().full_name.c_str());
64 }
65 }
66
67 void ArcTraceBridge::StartTracing(
68 const base::trace_event::TraceConfig& trace_config) {
69 DCHECK(thread_checker_.CalledOnValidThread());
70
71 auto* trace_instance =
72 arc_bridge_service()->trace()->GetInstanceForMethod("StartTracing");
73 if (!trace_instance)
74 return;
75
76 std::vector<std::string> selected_categories;
77 for (const auto& category : categories_) {
78 if (trace_config.IsCategoryGroupEnabled(category.full_name.c_str()))
79 selected_categories.push_back(category.name);
80 }
81
82 trace_instance->StartTracing(selected_categories,
83 base::Bind(&ArcTraceBridge::OnTraceStart,
84 weak_ptr_factory_.GetWeakPtr()));
85 }
86
87 void ArcTraceBridge::StopTracing() {
88 auto* trace_instance =
89 arc_bridge_service()->trace()->GetInstanceForMethod("StopTracing");
90 if (!trace_instance)
91 return;
92 trace_instance->StopTracing(
93 base::Bind(&ArcTraceBridge::OnTraceStop, weak_ptr_factory_.GetWeakPtr()));
94 }
95
96 void ArcTraceBridge::OnTraceStart(bool success) {
97 if (!success)
98 LOG(ERROR) << "Failed to start tracing in the container.";
99 }
100
101 void ArcTraceBridge::OnTraceStop(bool success) {
102 if (!success)
103 LOG(ERROR) << "Failed to stop tracing in the container.";
104 }
105
106 } // namespace arc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698