content/browser/tracing/DEPS - Issue 2400163003: arc: enable Android tracing in verified-boot mode

Side by Side Diff: content/browser/tracing/DEPS

Issue 2400163003: arc: enable Android tracing in verified-boot mode (Closed)

Patch Set: Use struct instead of pair to save category data and fix lints Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Generated by the local tracing_resources.gyp:tracing_resources	2 # Generated by the local tracing_resources.gyp:tracing_resources

3 "+grit/tracing_resources.h",	3 "+grit/tracing_resources.h",

4 "+third_party/zlib/zlib.h",	4 "+third_party/zlib/zlib.h",

5 "+tools/battor_agent",	5 "+tools/battor_agent",

6 ]	6 ]

7	7

8 specific_include_rules = {	8 specific_include_rules = {

9 "tracing_controller_impl\.cc": [	9 "tracing_controller_impl\.cc": [

10 "+v8"	10 "+v8",

	11 "+chrome/browser/chromeos",
	Yusuke Sato 2016/10/12 05:58:14 hmm.. is this okay? I don't have Chromium code acc hmm.. is this okay? I don't have Chromium code access right now, but my best guess is that there is no chrome/ dependencies in content/ atm. shunhsingou 2016/10/12 08:03:19 I tried to put codes (sys_trace_agent.) in chrome Show quoted text On 2016/10/12 05:58:14, Yusuke Sato wrote: > hmm.. is this okay? I don't have Chromium code access right now, but my best > guess is that there is no chrome/ dependencies in content/ atm. I tried to put codes (sys_trace_agent.) in chromeos/. However, this introduces components/arc dependencies in chromeos/, which causes a circular dependency (chromeos/ is in components/arc dependencies now). I'm still seeking solutions for this. Any suggestion? Yusuke Sato 2016/10/12 17:07:34 components/arc/DEPS only depends on a few chromeos Show quoted text On 2016/10/12 08:03:19, shunhsingou wrote: > On 2016/10/12 05:58:14, Yusuke Sato wrote: > > hmm.. is this okay? I don't have Chromium code access right now, but my best > > guess is that there is no chrome/ dependencies in content/ atm. > > I tried to put codes (sys_trace_agent.) in chromeos/. However, this introduces > components/arc dependencies in chromeos/, which causes a circular dependency > (chromeos/ is in components/arc dependencies now). > > I'm still seeking solutions for this. Any suggestion? components/arc/DEPS only depends on a few chromeos/ sub directories and header files. So if you move them to chromeos/<new_directory>/ (e.g. chromeos/tracing/ ?) and add DEPS (with +components/arc) to the new directory, that won't introduce a circular dependency. WDYT? You'd probably want to ask one of the chromeos/OWNERS though. shunhsingou* 2016/12/22 04:04:35 Changed according to the comment. Show quoted text On 2016/10/12 17:07:34, Yusuke Sato (ooo Dec 16 to 31) wrote: > On 2016/10/12 08:03:19, shunhsingou wrote: > > On 2016/10/12 05:58:14, Yusuke Sato wrote: > > > hmm.. is this okay? I don't have Chromium code access right now, but my best > > > guess is that there is no chrome/ dependencies in content/ atm. > > > > I tried to put codes (sys_trace_agent.*) in chromeos/. However, this > introduces > > components/arc dependencies in chromeos/, which causes a circular dependency > > (chromeos/ is in components/arc dependencies now). > > > > I'm still seeking solutions for this. Any suggestion? > > components/arc/DEPS only depends on a few chromeos/ sub directories and header > files. So if you move them to chromeos/<new_directory>/ (e.g. chromeos/tracing/ > ?) and add DEPS (with +components/arc) to the new directory, that won't > introduce a circular dependency. WDYT? You'd probably want to ask one of the > chromeos/OWNERS though. Changed according to the comment.
11 ]	12 ]

12 }	13 }

OLD	NEW

« components/arc/trace/arc_trace_bridge.cc ('K') | « components/arc/trace/arc_trace_bridge.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »