components/arc/common/trace.mojom - Issue 2400163003: arc: enable Android tracing in verified-boot mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/common/trace.mojom

Issue 2400163003: arc: enable Android tracing in verified-boot mode (Closed)

Patch Set: Use struct instead of pair to save category data and fix lints Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	Yusuke Sato 2016/10/12 05:58:13 // Next MinVersion: 1 // Next MinVersion: 1 shunhsingou 2016/12/22 04:04:34 Done. Show quoted text On 2016/10/12 05:58:13, Yusuke Sato (ooo Dec 16 to 31) wrote: > // Next MinVersion: 1 Done.
	5 module arc.mojom;

	6

	7 interface TraceHost {
	Yusuke Sato 2016/10/12 05:58:13 remove line 7-8? I'm not sure defining an empty ho remove line 7-8? I'm not sure defining an empty host makes sense. shunhsingou 2016/12/22 04:04:34 Removed Show quoted text On 2016/10/12 05:58:13, Yusuke Sato (ooo Dec 16 to 31) wrote: > remove line 7-8? I'm not sure defining an empty host makes sense. Removed
	8 };

	9

	10 interface TraceInstance {
	Yusuke Sato 2016/10/12 05:58:13 Mind adding comments to the interface and all meth Mind adding comments to the interface and all methods? That would help the security review etc. shunhsingou 2016/12/22 04:04:34 Done. Show quoted text On 2016/10/12 05:58:13, Yusuke Sato (ooo Dec 16 to 31) wrote: > Mind adding comments to the interface and all methods? That would help the > security review etc. Done.
	11 StartTracing@0(array<string> categories) => (bool success);
	Luis Héctor Chávez 2016/10/12 20:32:07 Is there any chance the TraceInstance will want to Is there any chance the TraceInstance will want to call any method of the TraceHost in the future? If so, it might be a good idea to declare Init@0(TraceHost host); just like the other interfaces. If there is exactly 0% chance, let's get rid of TraceHost altogether. shunhsingou 2016/12/22 04:04:34 Removed Show quoted text On 2016/10/12 20:32:07, Luis Héctor Chávez wrote: > Is there any chance the TraceInstance will want to call any method of the > TraceHost in the future? If so, it might be a good idea to declare > > Init@0(TraceHost host); > > just like the other interfaces. If there is exactly 0% chance, let's get rid of > TraceHost altogether. Removed
	12

	13 StopTracing@1() => (bool success);

	14

	15 QueryAvailableCategories@2() => (array<string> categories);
	Yusuke Sato 2016/10/12 05:58:13 sort sort shunhsingou 2016/12/22 04:04:34 Done. Show quoted text On 2016/10/12 05:58:13, Yusuke Sato (ooo Dec 16 to 31) wrote: > sort Done.
	16 };

OLD	NEW

« components/arc/arc_bridge_host_impl.cc ('K') | « components/arc/common/arc_bridge.mojom ('k') | components/arc/trace/arc_trace_bridge.h » ('j') | components/arc/trace/arc_trace_bridge.h » ('J')