chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java - Issue 2400163002: Tentative fix for scroll event related crashes on the NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2400163002: Tentative fix for scroll event related crashes on the NTP (Closed)

Patch Set: address comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

index 564b1c1eb15ae186c1a4b68a7d2687f157483909..0316586707af28178ece61d8c59e9e304409d2ce 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -60,6 +60,7 @@

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeSwitches;

+import org.chromium.chrome.browser.NativePage;

import org.chromium.chrome.browser.WindowDelegate;

import org.chromium.chrome.browser.appmenu.AppMenuButtonHelper;

import org.chromium.chrome.browser.ntp.NativePageFactory;

@@ -1135,6 +1136,12 @@ public void requestUrlFocusFromFakebox(String pastedText) {

}

@Override

+ public boolean isCurrentPage(NativePage nativePage) {

+ assert nativePage != null;

+ return nativePage == mToolbarDataProvider.getNewTabPageForCurrentTab();

+ }

+ @Override

public void showUrlBarCursorWithoutFocusAnimations() {

if (mUrlHasFocus || mUrlFocusedFromFakebox) return;