Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: components/ntp_snippets/remote/ntp_snippets_fetcher.h

Issue 2400133002: Sending LanguageModel info to suggestions server (Closed)
Patch Set: Zero initialization #2 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/DEPS ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/remote/ntp_snippets_fetcher.h
diff --git a/components/ntp_snippets/remote/ntp_snippets_fetcher.h b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
index 91f0915c6dafe55f572a9045c76af02c2bf10464..d100ddde0a550adee6e34d755a3cea29f1044e44 100644
--- a/components/ntp_snippets/remote/ntp_snippets_fetcher.h
+++ b/components/ntp_snippets/remote/ntp_snippets_fetcher.h
@@ -18,6 +18,7 @@
#include "base/time/time.h"
#include "components/ntp_snippets/remote/ntp_snippet.h"
#include "components/ntp_snippets/remote/request_throttler.h"
+#include "components/translate/core/browser/language_model.h"
#include "google_apis/gaia/oauth2_token_service.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "net/url_request/url_request_context_getter.h"
@@ -26,6 +27,7 @@ class PrefService;
class SigninManagerBase;
namespace base {
+class ListValue;
class Value;
} // namespace base
@@ -91,6 +93,7 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
PrefService* pref_service,
CategoryFactory* category_factory,
+ translate::LanguageModel* language_model,
const ParseJSONCallback& parse_json_callback,
const std::string& api_key);
~NTPSnippetsFetcher() override;
@@ -148,6 +151,12 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestAuthenticated);
FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestUnauthenticated);
FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest, BuildRequestExcludedIds);
+ FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest,
+ BuildRequestWithTwoLanguages);
+ FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest,
+ BuildRequestWithUILanguageOnly);
+ FRIEND_TEST_ALL_PREFIXES(NTPSnippetsFetcherTest,
+ BuildRequestWithOtherLanguageOnly);
enum FetchAPI {
CHROME_READER_API,
@@ -163,6 +172,8 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
std::set<std::string> excluded_ids;
int count_to_fetch;
bool interactive_request;
+ translate::LanguageModel::LanguageInfo ui_language;
+ translate::LanguageModel::LanguageInfo other_top_language;
RequestParams();
~RequestParams();
@@ -173,6 +184,7 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
void FetchSnippetsImpl(const GURL& url,
const std::string& auth_header,
const std::string& request);
+ void SetUpCommonFetchingParameters(RequestParams* params) const;
void FetchSnippetsNonAuthenticated();
void FetchSnippetsAuthenticated(const std::string& account_id,
const std::string& oauth_access_token);
@@ -208,7 +220,10 @@ class NTPSnippetsFetcher : public OAuth2TokenService::Consumer,
// Holds the URL request context.
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
+ // Weak references, not owned.
CategoryFactory* const category_factory_;
+ translate::LanguageModel* const language_model_;
+
const ParseJSONCallback parse_json_callback_;
base::TimeTicks fetch_start_time_;
std::string last_status_;
« no previous file with comments | « components/ntp_snippets/DEPS ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698