Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 240013007: Remove some dead code from inspector/ (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove some dead code from inspector/ Remove some dead code from inspector/. Several functions but defined but not used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -89 lines) Patch
M Source/core/inspector/ContentSearchUtils.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/ContentSearchUtils.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/NetworkResourcesData.cpp View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 8 months ago (2014-04-17 04:19:55 UTC) #1
pfeldman
Wow :) Thanks! lgtm
6 years, 8 months ago (2014-04-17 06:01:29 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-17 12:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/240013007/1
6 years, 8 months ago (2014-04-17 12:05:53 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 14:05:00 UTC) #5
Message was sent while issue was closed.
Change committed as 171858

Powered by Google App Engine
This is Rietveld 408576698