telemetry/telemetry/internal/actions/navigate.py - Issue 2400123002: Wait a frame before finishing navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/actions/navigate.py

Issue 2400123002: Wait a frame before finishing navigation (Closed)

Patch Set: Add method to FakeTab to fix tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/internal/actions/navigate.py

diff --git a/telemetry/telemetry/internal/actions/navigate.py b/telemetry/telemetry/internal/actions/navigate.py

index 353eb66b38067d14cb5560358cf85f4ddb7a358e..c2a81fdc759902f4db3fef5ee64a731d44f2009c 100644

--- a/telemetry/telemetry/internal/actions/navigate.py

+++ b/telemetry/telemetry/internal/actions/navigate.py

@@ -27,3 +27,4 @@ class NavigateAction(page_action.PageAction):

time_left_in_seconds = max(0, time_left_in_seconds)

tab.WaitForDocumentReadyStateToBeInteractiveOrBetter(

time_left_in_seconds)

+ tab.WaitForFrameToBeDisplayed()

« no previous file with comments | « no previous file | telemetry/telemetry/testing/fakes/__init__.py » ('j') | no next file with comments »