Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2400113002: [MD settings] align paper-input by baseline (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] align paper-input by baseline Adjust paper-inputs that have elements before or after to line up by their text baselines. BUG=651340 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/51458ec148c09cf7f75feca928c22d6bf9cedb3d Cr-Commit-Position: refs/heads/master@{#424028}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 2 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/settings_vars_css.html View 2 chunks +6 lines, -2 lines 1 comment Download

Messages

Total messages: 15 (10 generated)
dschuyler
4 years, 2 months ago (2016-10-07 22:54:44 UTC) #8
hcarmona
LGTM https://codereview.chromium.org/2400113002/diff/1/chrome/browser/resources/settings/settings_vars_css.html File chrome/browser/resources/settings/settings_vars_css.html (left): https://codereview.chromium.org/2400113002/diff/1/chrome/browser/resources/settings/settings_vars_css.html#oldcode59 chrome/browser/resources/settings/settings_vars_css.html:59: :root { Nice
4 years, 2 months ago (2016-10-07 23:41:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400113002/1
4 years, 2 months ago (2016-10-08 00:32:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 00:37:21 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 00:41:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51458ec148c09cf7f75feca928c22d6bf9cedb3d
Cr-Commit-Position: refs/heads/master@{#424028}

Powered by Google App Engine
This is Rietveld 408576698