Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2400093002: [Devtools] New network timeline experiment Part 1 (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 */ 420 */
421 _showRequest: function(request) 421 _showRequest: function(request)
422 { 422 {
423 if (this._networkItemView) { 423 if (this._networkItemView) {
424 this._networkItemView.detach(); 424 this._networkItemView.detach();
425 this._networkItemView = null; 425 this._networkItemView = null;
426 } 426 }
427 427
428 if (request) { 428 if (request) {
429 this._networkItemView = new WebInspector.NetworkItemView(request, th is._networkLogView.timeCalculator()); 429 this._networkItemView = new WebInspector.NetworkItemView(request, th is._networkLogView.timeCalculator());
430 if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
dgozman 2016/10/08 00:36:41 I think is not needed anymore.
allada 2016/10/08 01:09:01 Done.
431 this._splitWidget.setMainWidget(this._detailsWidget);
430 this._networkItemView.leftToolbar().appendToolbarItem(new WebInspect or.ToolbarItem(this._closeButtonElement)); 432 this._networkItemView.leftToolbar().appendToolbarItem(new WebInspect or.ToolbarItem(this._closeButtonElement));
431 this._networkItemView.show(this._detailsWidget.element); 433 this._networkItemView.show(this._detailsWidget.element);
432 this._splitWidget.showBoth(); 434 this._splitWidget.showBoth();
433 } else { 435 } else {
434 this._splitWidget.hideMain(); 436 this._splitWidget.hideMain();
435 this._networkLogView.clearSelection(); 437 this._networkLogView.clearSelection();
436 } 438 }
437 this._updateUI(); 439 this._updateUI();
438 }, 440 },
439 441
440 _updateUI: function() 442 _updateUI: function()
441 { 443 {
442 this._detailsWidget.element.classList.toggle("network-details-view-tall- header", this._networkLogLargeRowsSetting.get()); 444 this._detailsWidget.element.classList.toggle("network-details-view-tall- header", this._networkLogLargeRowsSetting.get());
443 this._networkLogView.switchViewMode(!this._splitWidget.isResizable()); 445 this._networkLogView.switchViewMode(!this._networkItemView);
dgozman 2016/10/08 00:36:41 And this can be reverted as well.
allada 2016/10/08 01:09:01 Done.
444 }, 446 },
445 447
446 /** 448 /**
447 * @override 449 * @override
448 * @param {!WebInspector.SearchableView.SearchConfig} searchConfig 450 * @param {!WebInspector.SearchableView.SearchConfig} searchConfig
449 * @param {boolean} shouldJump 451 * @param {boolean} shouldJump
450 * @param {boolean=} jumpBackwards 452 * @param {boolean=} jumpBackwards
451 */ 453 */
452 performSearch: function(searchConfig, shouldJump, jumpBackwards) 454 performSearch: function(searchConfig, shouldJump, jumpBackwards)
453 { 455 {
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 * @return {boolean} 779 * @return {boolean}
778 */ 780 */
779 handleAction: function(context, actionId) 781 handleAction: function(context, actionId)
780 { 782 {
781 var panel = WebInspector.context.flavor(WebInspector.NetworkPanel); 783 var panel = WebInspector.context.flavor(WebInspector.NetworkPanel);
782 console.assert(panel && panel instanceof WebInspector.NetworkPanel); 784 console.assert(panel && panel instanceof WebInspector.NetworkPanel);
783 panel._toggleRecording(); 785 panel._toggleRecording();
784 return true; 786 return true;
785 } 787 }
786 } 788 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698