Don't break before a first in-flow block container.

Don't break before a first in-flow block container.

There's no break opportunity there, but break-inside:avoid used to trick us
into inserting a break there anyway in some cases.

As part of this work, we need allowsPaginationStrut() to check better if a
strut is allowed, or it might just end up getting eaten and forgotten about by
a first in-flow block further up in the tree. This matters for monolithic
content [1], such as lines and image blocks. We should never break inside
those, so allow breaking before them, even if they are the first piece of
content inside some block (just like we did before this change).
break-before-first-line-in-first-child.html and image-block-as-first-child.html
test that we don't regress in this regard.

Also removed a FIXME about checking for sufficient height. This would be
incorrect to fix. If there's no break point here, we have to propagate the
strut, if we're allowed to.

Had to update some tests, and even rename one, because they relied on the old
buggy behavior.

[1] https://drafts.csswg.org/css-break-3/#possible-breaks

BUG=653690
Committed: https://crrev.com/256093e6ead7db6f7269d8af50a82906891f0caf
Cr-Commit-Position: refs/heads/master@{#423926}

[mstensho (USE GERRIT), 2016-10-07 17:08:44]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 17:09:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:20:58]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2016-10-07 18:47:41]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[eae, 2016-10-07 18:56:10]

OK, LGTM

[mstensho (USE GERRIT), 2016-10-07 19:09:22]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-10-07 19:09:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:21:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 19:24:50]

Description was changed from

==========
Don't break before a first in-flow block container.

There's no break opportunity there, but break-inside:avoid used to trick us
into inserting a break there anyway in some cases.

As part of this work, we need allowsPaginationStrut() to check better if a
strut is allowed, or it might just end up getting eaten and forgotten about by
a first in-flow block further up in the tree. This matters for monolithic
content [1], such as lines and image blocks. We should never break inside
those, so allow breaking before them, even if they are the first piece of
content inside some block (just like we did before this change).
break-before-first-line-in-first-child.html and image-block-as-first-child.html
test that we don't regress in this regard.

Also removed a FIXME about checking for sufficient height. This would be
incorrect to fix. If there's no break point here, we have to propagate the
strut, if we're allowed to.

Had to update some tests, and even rename one, because they relied on the old
buggy behavior.

[1] https://drafts.csswg.org/css-break-3/#possible-breaks

BUG=653690
==========

to

==========
Don't break before a first in-flow block container.

There's no break opportunity there, but break-inside:avoid used to trick us
into inserting a break there anyway in some cases.

As part of this work, we need allowsPaginationStrut() to check better if a
strut is allowed, or it might just end up getting eaten and forgotten about by
a first in-flow block further up in the tree. This matters for monolithic
content [1], such as lines and image blocks. We should never break inside
those, so allow breaking before them, even if they are the first piece of
content inside some block (just like we did before this change).
break-before-first-line-in-first-child.html and image-block-as-first-child.html
test that we don't regress in this regard.

Also removed a FIXME about checking for sufficient height. This would be
incorrect to fix. If there's no break point here, we have to propagate the
strut, if we're allowed to.

Had to update some tests, and even rename one, because they relied on the old
buggy behavior.

[1] https://drafts.csswg.org/css-break-3/#possible-breaks

BUG=653690

Committed: https://crrev.com/256093e6ead7db6f7269d8af50a82906891f0caf
Cr-Commit-Position: refs/heads/master@{#423926}
==========

[commit-bot: I haz the power, 2016-10-07 19:24:51]

Patchset 1 (id:??) landed as
https://crrev.com/256093e6ead7db6f7269d8af50a82906891f0caf
Cr-Commit-Position: refs/heads/master@{#423926}