Adds more BUILD.gns to ash

Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/23ca8fd201f99a8574c96d6ce8fa9c7457704a1d
Cr-Commit-Position: refs/heads/master@{#424015}

[sky, 2016-10-07 21:18:46]

Description was changed from

==========
Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org
==========

to

==========
Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org
==========

[sky, 2016-10-07 21:18:46]

sky@chromium.org changed reviewers:
+ reveman@chromium.org

[sky, 2016-10-07 21:18:56]

+reveman for exo

[sky, 2016-10-07 21:19:10]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 21:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 21:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:46:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-10-07 21:50:47]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 21:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-10-07 21:56:08]

components/exo lgtm

[msw, 2016-10-07 22:02:25]

https://codereview.chromium.org/2400063003/diff/40001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/BUILD.gn#newcode1333
ash/BUILD.gn:1333: "//ash/common:unittests",
q: sanity check (my memory is fuzzy); this is sufficient to run the
ash/common:unittests source-set's tests in ash_unittests, right?

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn
File ash/common/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:5: import("//build/config/features.gni")
q: what is this needed for? (maybe is_chromeos, but I don't see it)

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:6: import("//build/config/ui.gni")
nit: probably not needed yet (but maybe will be eventually).

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:7: import("//testing/test.gni")
nit: not needed (using source_set here instead of test)

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:8: import("//ui/base/ui_features.gni")
nit: probably not needed yet (but maybe will be eventually).

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.gn
File ash/common/test/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:5: import("//build/config/features.gni")
ditto: please audit imports.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:33: "//components/signin/core/account_id:account_id",
optional nit: omit redundant 'account_id' target name; ditto below

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:36: # For ui/wm/public/window_types.h, which shouldn't
be in aura.
nit: file a bug and/or add TODOs? (or move to ui/wm target?)

https://codereview.chromium.org/2400063003/diff/40001/ash/test/BUILD.gn
File ash/test/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/test/BUILD.gn#newcode5
ash/test/BUILD.gn:5: import("//build/config/features.gni")
ditto: please audit imports.

https://codereview.chromium.org/2400063003/diff/40001/mash/BUILD.gn
File mash/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/mash/BUILD.gn#newcode42
mash/BUILD.gn:42: "//ash/common:unittests",
q: sanity check (my memory is fuzzy); this is sufficient to run the
ash/common:unittests source-set's tests in mash_unittests, right?

[sky, 2016-10-07 22:22:38]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 22:22:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-10-07 22:23:14]

Thanks for the great review (as usual)!

https://codereview.chromium.org/2400063003/diff/40001/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/BUILD.gn#newcode1333
ash/BUILD.gn:1333: "//ash/common:unittests",
On 2016/10/07 22:02:24, msw wrote:
> q: sanity check (my memory is fuzzy); this is sufficient to run the
> ash/common:unittests source-set's tests in ash_unittests, right?

Indeed it is.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn
File ash/common/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:5: import("//build/config/features.gni")
On 2016/10/07 22:02:24, msw wrote:
> q: what is this needed for? (maybe is_chromeos, but I don't see it)

I got lazy. I had one error and copied all the imports. Apparently none of these
are necessary, nuked.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:6: import("//build/config/ui.gni")
On 2016/10/07 22:02:24, msw wrote:
> nit: probably not needed yet (but maybe will be eventually).

Done.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:7: import("//testing/test.gni")
On 2016/10/07 22:02:24, msw wrote:
> nit: not needed (using source_set here instead of test)

Done.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/BUILD.gn#new...
ash/common/BUILD.gn:8: import("//ui/base/ui_features.gni")
On 2016/10/07 22:02:24, msw wrote:
> nit: probably not needed yet (but maybe will be eventually).

Done.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.gn
File ash/common/test/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:5: import("//build/config/features.gni")
On 2016/10/07 22:02:24, msw wrote:
> ditto: please audit imports.

Done.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:33: "//components/signin/core/account_id:account_id",
On 2016/10/07 22:02:24, msw wrote:
> optional nit: omit redundant 'account_id' target name; ditto below

Done.

https://codereview.chromium.org/2400063003/diff/40001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:36: # For ui/wm/public/window_types.h, which shouldn't
be in aura.
On 2016/10/07 22:02:24, msw wrote:
> nit: file a bug and/or add TODOs? (or move to ui/wm target?)

Done.

https://codereview.chromium.org/2400063003/diff/40001/ash/test/BUILD.gn
File ash/test/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/ash/test/BUILD.gn#newcode5
ash/test/BUILD.gn:5: import("//build/config/features.gni")
On 2016/10/07 22:02:25, msw wrote:
> ditto: please audit imports.

Done.

https://codereview.chromium.org/2400063003/diff/40001/mash/BUILD.gn
File mash/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/40001/mash/BUILD.gn#newcode42
mash/BUILD.gn:42: "//ash/common:unittests",
On 2016/10/07 22:02:25, msw wrote:
> q: sanity check (my memory is fuzzy); this is sufficient to run the
> ash/common:unittests source-set's tests in mash_unittests, right?

Indeed it is.

[msw, 2016-10-07 22:48:08]

lgtm with a nit

https://codereview.chromium.org/2400063003/diff/80001/ash/common/test/BUILD.gn
File ash/common/test/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/80001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:28: "//components/signin/core/account_id:",
nit: remove trailing ':'

[sky, 2016-10-07 22:50:44]

https://codereview.chromium.org/2400063003/diff/80001/ash/common/test/BUILD.gn
File ash/common/test/BUILD.gn (right):

https://codereview.chromium.org/2400063003/diff/80001/ash/common/test/BUILD.g...
ash/common/test/BUILD.gn:28: "//components/signin/core/account_id:",
On 2016/10/07 22:48:08, msw wrote:
> nit: remove trailing ':'

Done.

[sky, 2016-10-07 22:51:18]

The CQ bit was checked by sky@chromium.org

[sky, 2016-10-07 22:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2400063003/#ps100001
(title: "feedback")

[commit-bot: I haz the power, 2016-10-07 22:51:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 23:40:30]

Description was changed from

==========
Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org
==========

to

==========
Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org
==========

[commit-bot: I haz the power, 2016-10-07 23:40:32]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-07 23:42:28]

Description was changed from

==========
Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org
==========

to

==========
Adds more BUILD.gns to ash

This adds BUILD.gn for ash/test, ash/common and ash/common/test. This
helps better separate dependencies and make it clear who uses what.

BUG=none
TEST=none
R=msw@chromium.org

Committed: https://crrev.com/23ca8fd201f99a8574c96d6ce8fa9c7457704a1d
Cr-Commit-Position: refs/heads/master@{#424015}
==========

[commit-bot: I haz the power, 2016-10-07 23:42:29]

Patchset 6 (id:??) landed as
https://crrev.com/23ca8fd201f99a8574c96d6ce8fa9c7457704a1d
Cr-Commit-Position: refs/heads/master@{#424015}