Chromium Code Reviews| Index: chrome/browser/resources/settings/device_page/display_layout.js |
| diff --git a/chrome/browser/resources/settings/device_page/display_layout.js b/chrome/browser/resources/settings/device_page/display_layout.js |
| index eb1931f825f06cf0ef616bb92b173db4a1ca4043..db8bb3f44cdad0e3b6a4b97727645e17a870bfd8 100644 |
| --- a/chrome/browser/resources/settings/device_page/display_layout.js |
| +++ b/chrome/browser/resources/settings/device_page/display_layout.js |
| @@ -179,12 +179,13 @@ Polymer({ |
| /** |
| * @param {!{model: !{item: !chrome.system.display.DisplayUnitInfo}, |
| - * target: !PaperButtonElement}} e |
| + * target: !HTMLDivElement}} e |
| * @private |
| */ |
| onSelectDisplayTap_: function(e) { |
| this.fire('select-display', e.model.item.id); |
| // Force active in case the selected display was clicked. |
| + // TODO(dpapad): Ask @stevenjb, why are we setting 'active' on a div? |
| e.target.active = true; |
| }, |
| @@ -192,7 +193,7 @@ Polymer({ |
| * @param {string} id |
| * @param {?DragPosition} amount |
| */ |
| - onDrag_(id, amount) { |
| + onDrag_: function(id, amount) { |
|
dpapad
2016/10/10 17:52:47
How was this working before?
michaelpg
2016/10/10 23:49:41
Valid ES6
dpapad
2016/10/11 00:17:49
Did not know that ES6 class syntax can be used wit
|
| id = id.substr(1); // Skip prefix |
| var newBounds; |