Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2400043002: [MD Feedback] Add dialog title. (Closed)

Created:
4 years, 2 months ago by apacible
Modified:
4 years, 2 months ago
Reviewers:
afakhry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Feedback] Add dialog title. This replaces the "Unknown" title that appears in desktop nav with "Feedback". BUG=654046 Committed: https://crrev.com/baf0f65bc3c4abbf7c75a1f1626de7013c57d2dc Cr-Commit-Position: refs/heads/master@{#425349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_feedback/md_feedback_dialog_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
apacible
PTAL, thanks!
4 years, 2 months ago (2016-10-07 21:01:13 UTC) #8
afakhry
lgtm
4 years, 2 months ago (2016-10-12 16:39:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400043002/1
4 years, 2 months ago (2016-10-14 15:45:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:28:22 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:31:01 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baf0f65bc3c4abbf7c75a1f1626de7013c57d2dc
Cr-Commit-Position: refs/heads/master@{#425349}

Powered by Google App Engine
This is Rietveld 408576698