Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2400033003: [Mac] Activate notifications on mouse *up*. (Closed)

Created:
4 years, 2 months ago by Sidney San Martín
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Activate notifications on mouse *up*. Buttons respond on mouse up. This is nice because it gives the user a chance to change their mind by moving the mouse away from the button before releasing. This makes notifications behave the same way. BUG=653862 Committed: https://crrev.com/e006b13348406840e21deaa6b77e7efb5862e960 Cr-Commit-Position: refs/heads/master@{#423877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M ui/message_center/cocoa/notification_controller.mm View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sidney San Martín
4 years, 2 months ago (2016-10-07 14:50:58 UTC) #2
Avi (use Gerrit)
lgtm 👍
4 years, 2 months ago (2016-10-07 16:11:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400033003/1
4 years, 2 months ago (2016-10-07 16:12:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 16:27:37 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:31:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e006b13348406840e21deaa6b77e7efb5862e960
Cr-Commit-Position: refs/heads/master@{#423877}

Powered by Google App Engine
This is Rietveld 408576698