Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 240003009: [Android]: Fix incorrect use of jint for pointer in ContentViewCoreImpl (Closed)

Created:
6 years, 8 months ago by rmcilroy
Modified:
6 years, 8 months ago
Reviewers:
bulach
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_atomics
Visibility:
Public.

Description

[Android]: Fix incorrect use of jint for pointer in ContentViewCoreImpl BUG=354405, 346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
rmcilroy
PTAL Marcus.
6 years, 8 months ago (2014-04-17 16:03:38 UTC) #1
bulach
lgtm, thanks!
6 years, 8 months ago (2014-04-17 16:05:55 UTC) #2
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 8 months ago (2014-04-17 16:07:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/240003009/1
6 years, 8 months ago (2014-04-17 16:08:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 16:37:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_rel_device_ninja for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device_ninja&number=11622
6 years, 8 months ago (2014-04-17 16:37:23 UTC) #6
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 8 months ago (2014-04-17 16:59:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/240003009/1
6 years, 8 months ago (2014-04-17 17:00:12 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 19:06:50 UTC) #9
Message was sent while issue was closed. 
Change committed as 264604

Powered by Google App Engine
This is Rietveld 408576698